Review 12.4 Merged

78928[BUGFIX] Use proper type for recovery emails

Oliver Hader CR +2 V +2 Easy +4 −5 updated 05/03/23, 22:37

Commit message

RecoveryService::prepareMail creates a FluidEmail, but
returns it as Symfony\Component\Mime\Email. Setting the
signature to the proper type, which also is used in the
SendRecoveryEmailEvent, allows easier adjustment of the
sent email.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 47

  1. Oliver Hader uploaded patch set 1 05/03/23, 13:11

  2. core-ci voted on patch set 1 V -1 05/03/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41536

  3. Oliver Hader rebased onto patch set 2 V -1 05/03/23, 21:33

  4. core-ci voted on patch set 2 V +1 05/03/23, 21:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41554

  5. core-ci commented on patch set 2 05/03/23, 22:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41556

  6. Oliver Hader voted on patch set 2 V +2 CR +2 05/03/23, 22:37

  7. Oliver Hader merged patch set 3 05/03/23, 22:37