Review main Merged

78931[DOCS] Correct example for AfterLinkIsGeneratedEvent in changelog

Chris Müller CR +2 V +2 Easy +1 −1 updated 05/04/23, 07:35

Commit message

The method "withAttribute()" expects a string or null as second argument.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Chris Müller uploaded patch set 1 05/03/23, 17:02

  2. Chris Müller updated the commit message in patch set 2 05/03/23, 17:03

  3. core-ci voted on patch set 1 V +1 05/03/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41547

  4. core-ci voted on patch set 2 V +1 05/03/23, 17:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41548

  5. Georg Ringer voted on patch set 2 V +1 CR +1 05/03/23, 19:43

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 05/04/23, 07:35

  7. Christian Kuhn merged patch set 3 05/04/23, 07:35