Review main Merged

78933[BUGFIX] Correctly represent CSP UriValue('*')

Oliver Hader CR +2 V +2 Easy +15 −0 updated 05/09/23, 07:29

Commit message

An entire wildcard `UriValue`, which is just `'*'`, was
incorrectly encoded. In the scope of CSP `'*'` is valid.
Using wildcards should be avoided in favor of being specific.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Oliver Hader uploaded patch set 1 05/04/23, 12:24

  2. core-ci voted on patch set 1 V +1 05/04/23, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41572

  3. Georg Ringer voted on patch set 1 V +1 CR +1 05/04/23, 15:45

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 05/05/23, 08:58

  5. Benni Mack voted on patch set 1 V +1 CR +1 05/07/23, 07:24

  6. Oliver Hader voted on patch set 1 V +2 CR +2 05/09/23, 07:29

  7. Oliver Hader merged patch set 2 05/09/23, 07:29