Review main Merged

78958[BUGFIX] Do not call getConflictingRedirects with null request

Lina Wolf CR +2 V +2 Easy +1 −3 updated 05/15/23, 19:22

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Lina Wolf uploaded patch set 1 05/08/23, 07:36

  2. core-ci voted on patch set 1 V +1 05/08/23, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41654

  3. Oliver Klee voted on patch set 1 CR +1 05/08/23, 07:57

  4. Oli Bartsch commented on patch set 1 05/08/23, 13:34

    RedirectStatus.php:46

    What do you think about return $request !== null ? ['Conflicts' => $this->getConflictingRedirects($request)] : [];
  5. Lina Wolf commented on patch set 1 05/08/23, 15:53

    RedirectStatus.php:46 Reply

    I think the expected return should be last
  6. Stefan Bürk commented on patch set 1 05/11/23, 18:00

    RedirectStatus.php:46 Reply

    The null check could be omitted in this case, but it does not hurt. But I'm here with the suggestion from Oliver, the "expected" result should be more the first thing and the fallback value the last part. (similar to null collasce operator etc).
  7. Lina Wolf uploaded patch set 2 CR +1 V +1 05/13/23, 19:25

  8. Lina Wolf commented on patch set 2 05/13/23, 19:27

    RedirectStatus.php:46 Reply

    Done
  9. core-ci voted on patch set 2 V +1 05/13/23, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41799

  10. Oliver Klee voted on patch set 2 CR +1 05/13/23, 19:33

  11. Oli Bartsch voted on patch set 2 V +1 CR +1 05/15/23, 06:52

  12. Stefan Bürk voted on patch set 2 V +2 CR +2 05/15/23, 19:22

  13. Stefan Bürk merged patch set 3 05/15/23, 19:22