Review main Merged

78959[BUGFIX] Preserve native CKEditor5 related toolbar settings

Stefan Froemken CR +2 V +2 Normal +92 −2 updated 09/15/23, 10:45

Commit message

If the CKEditor is configured with the new v5-style
`toolbar.removeItems` option instead of `removeButtons` (v4), the
CKEditor5Migrator will now merge`removeItems` with `removeButtons`.

Also do not overwrite `toolbar.shouldNotGroupWhenFull`, allowing
it to be set to false.

Note that v5-style `toolbar.items` where already defined to
be used when v4-style `toolbarGroups` are empty, so we do
not change this behavior.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 710

  1. Stefan Froemken uploaded patch set 1 05/08/23, 10:37

  2. core-ci voted on patch set 1 V +1 05/08/23, 10:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41658

  3. Stefan Froemken uploaded patch set 2 V +1 05/09/23, 13:18

  4. core-ci voted on patch set 2 V +1 05/09/23, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41706

  5. Oliver Klee voted on patch set 2 V +1 05/09/23, 16:06

  6. Benjamin Franzke uploaded patch set 3 V +1 09/15/23, 08:34

  7. core-ci voted on patch set 3 V +1 09/15/23, 08:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46595

  8. Benjamin Kott voted on patch set 3 V +1 CR +1 09/15/23, 08:58

  9. Benjamin Franzke voted on patch set 3 V +2 CR +2 09/15/23, 09:32

  10. Benjamin Franzke merged patch set 4 09/15/23, 10:45