Review main Merged

78994[BUGFIX] Respect multiple classes in CKEditor5 allowedClasses migrator

Stefan Froemken CR +2 V +2 Easy +15 −9 updated 10/05/23, 09:36

Commit message

While migrating CKEditor5 property
buttons.link.properties.class.allowedClasses
the CKEditor5Migrator will now respect multiple classes.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1114

  1. Stefan Froemken uploaded patch set 1 05/09/23, 07:17

  2. core-ci voted on patch set 1 V +1 05/09/23, 07:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41689

  3. Andreas Kienast commented on patch set 1 CR -1 05/09/23, 07:36

    Can you please provide tests?
  4. Stefan Froemken uploaded patch set 2 CR -1 V +1 05/09/23, 13:00

  5. Stefan Froemken commented on patch set 2 05/09/23, 13:00

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 05/09/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41704

  7. Oliver Klee voted on patch set 2 V +1 05/09/23, 13:14

  8. Jörg Bösche voted on patch set 2 CR +1 07/07/23, 12:13

  9. Benjamin Franzke uploaded patch set 3 CR +1 V +1 10/04/23, 11:25

  10. Benjamin Franzke voted on patch set 3 V +1 CR +1 10/04/23, 11:26

  11. core-ci voted on patch set 3 V +1 10/04/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47393

  12. Benjamin Kott voted on patch set 3 V +1 CR +1 10/05/23, 09:04

  13. Benjamin Franzke voted on patch set 3 V +2 CR +2 10/05/23, 09:05

  14. Benjamin Franzke merged patch set 4 10/05/23, 09:36