Review main Merged

79003[BUGFIX] Fix type error in for pageType in f:uri.page ViewHelper

Stefan Froemken CR +2 V +2 Easy +9 −1 updated 05/23/23, 04:18

Commit message

The Fluid ViewHelper `f:uri.page` will now cast argument `pageType` to
int before using it.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1114

  1. Stefan Froemken uploaded patch set 1 05/09/23, 12:43

  2. core-ci voted on patch set 1 V +1 05/09/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41702

  3. Oliver Klee voted on patch set 1 CR +1 05/09/23, 13:13

  4. Georg Ringer commented on patch set 1 V +1 CR +1 05/09/23, 13:59

    also something for 11 I guess
  5. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 05/09/23, 14:22

  6. Oliver Klee commented on patch set 2 V +1 CR +1 05/09/23, 14:22

    Reply

    Done.
  7. core-ci voted on patch set 2 V +1 05/09/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41707

  8. Stefan Bürk commented on patch set 2 05/11/23, 17:48

    PageViewHelper.php:220

    Couldn't we trade the tenary with a single null coalesce operator ? ```php $pageType = (int)($arguments['pageType'] ?? 0); ```
  9. Stefan Froemken uploaded patch set 3 CR +1 V +1 05/22/23, 07:49

  10. Stefan Froemken commented on patch set 3 05/22/23, 07:51

    PageViewHelper.php:220 Reply

    Hi. I had copied that line from Link/PageViewHelper.php to have the same syntax.
  11. core-ci voted on patch set 3 V +1 05/22/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41958

  12. Oliver Klee voted on patch set 3 V +1 CR +1 05/22/23, 07:59

  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 05/23/23, 04:18

  14. Anja Leichsenring merged patch set 4 05/23/23, 04:18