79003[BUGFIX] Fix type error in for pageType in f:uri.page ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1114
-
Stefan Froemken uploaded patch set 1 05/09/23, 12:43
-
core-ci voted on patch set 1 V +1 05/09/23, 12:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41702
-
Oliver Klee voted on patch set 1 CR +1 05/09/23, 13:13
-
Georg Ringer commented on patch set 1 V +1 CR +1 05/09/23, 13:59
also something for 11 I guess -
Oliver Klee updated the commit message in patch set 2
CR +1V +105/09/23, 14:22 -
Oliver Klee commented on patch set 2 V +1 CR +1 05/09/23, 14:22
Reply
Done. -
core-ci voted on patch set 2 V +1 05/09/23, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41707
-
Stefan Bürk commented on patch set 2 05/11/23, 17:48
PageViewHelper.php:220Couldn't we trade the tenary with a single null coalesce operator ? ```php $pageType = (int)($arguments['pageType'] ?? 0); ``` -
Stefan Froemken uploaded patch set 3
CR +1V +105/22/23, 07:49 -
Stefan Froemken commented on patch set 3 05/22/23, 07:51
PageViewHelper.php:220ReplyHi. I had copied that line from Link/PageViewHelper.php to have the same syntax. -
core-ci voted on patch set 3 V +1 05/22/23, 07:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41958
-
Oliver Klee voted on patch set 3 V +1 CR +1 05/22/23, 07:59
-
Anja Leichsenring voted on patch set 3 V +2 CR +2 05/23/23, 04:18
-
Anja Leichsenring merged patch set 4 05/23/23, 04:18