Review main Merged

79004[BUGFIX] Check for ProviderRegistry when registering configuration providers

Oli Bartsch CR +2 V +2 Normal +52 −26 updated 06/02/23, 09:39

Commit message

Ensure ext:lowlevel ProviderRegistry is available before
tagging a service as configuration.provider, preventing
"Invalid service" errors on building the container.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Frank Nägler +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Sybille Peters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1417

  1. Oli Bartsch uploaded patch set 1 05/09/23, 16:04

  2. core-ci voted on patch set 1 V +1 05/09/23, 16:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41709

  3. Oli Bartsch uploaded patch set 2 V +1 05/09/23, 16:22

  4. core-ci voted on patch set 2 V +1 05/09/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41710

  5. Göran Bodenschatz voted on patch set 2 CR +1 05/15/23, 09:33

  6. Benni Mack commented on patch set 2 05/31/23, 14:59

    tbh, the main issue is the registration in the Services yaml, which is conditional. If we move this to a PHP Attribute the attribute would only be evaluated the attribute / tag is used to be wired in the autowiring process.
  7. Oli Bartsch commented on patch set 2 06/01/23, 08:14

    Reply

    This would just be another registration alternative, which however would still fail in case ext:lowlevel is loaded after an extension, using such attribute, right?
  8. Oli Bartsch commented on patch set 2 06/01/23, 08:21

    Reply

    Also changing registration would be a breaking change, wouldn't it?
  9. Oli Bartsch updated the commit message in patch set 3 CR +1 V +1 06/01/23, 08:37

  10. Oli Bartsch commented on patch set 3 06/01/23, 08:39

    Reply

    Checked this again and even without this patch, the extension loading order problem exists. Therefore, I suggest to get this patch in, to fix the errors a lot of people are currently facing and resolve the loading order issue in a separate patch.
  11. core-ci voted on patch set 3 V +1 06/01/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42137

  12. Frank Nägler voted on patch set 3 CR +1 06/01/23, 11:08

  13. Sybille Peters commented on patch set 3 V +1 06/02/23, 06:23

    I could reproduce the problem with installing dev-main of base distri. composer create-project typo3/cms-base-distribution:dev-main t3intro13 cd t3intro13 # appropriate passwords used, DB exists and access granted vendor/bin/typo3 setup --driver=mysqli --host=localhost --dbname=t3intro13 --username=typo3 --password='mypasswd...' --project-name=t3intro13 --force -n --port=3306 --admin-username=system --admin-user-password='mypasswd' --admin-email="myemail@mydomain" Exception: Invalid service "lowlevel.configuration.module.provider.webhooks": class "TYPO3\CMS\Lowlevel\ConfigurationModuleProvider\AbstractProvider" not found while loading "TYPO3\CMS\Webhooks\ConfigurationModuleProvider\Webhoo kTypesProvider". I could verify that the exception no longer occurs by applying the changes in patch and re-running the setup
  14. Andreas Kienast voted on patch set 3 V +1 CR +1 06/02/23, 06:52

  15. Benni Mack commented on patch set 3 06/02/23, 07:02

    Reply

    Ack
  16. Oli Bartsch voted on patch set 3 V +2 CR +2 06/02/23, 09:38

  17. Oli Bartsch merged patch set 4 06/02/23, 09:39