Review main Merged

79006[BUGFIX] Add font plugin to CKEditor5

Johannes Nielsen CR +2 V +2 Hard +272 −62 updated 02/19/24, 04:47

Commit message

Add the configuration to the "Full" RTE preset, and also
include some modules that missed in Full preset since #102099.

npm install --save @ckeditor/ckeditor5-font@41.1.0
npm run build

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Torben Hansen +1
    • David Bruchmann +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • Torben Hansen +1
    • David Bruchmann +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 67

Show 47 more files

Review log 76103

Show 5678 earlier messages
  1. Johannes Nielsen uploaded patch set 1 05/10/23, 07:04

  2. core-ci voted on patch set 1 V +1 05/10/23, 07:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41718

  3. Georg Ringer commented on patch set 1 05/10/23, 07:29

    should we also add the TableCaption plugin as requested in the issue?
  4. Johannes Nielsen uploaded patch set 2 V +1 05/10/23, 08:13

  5. Johannes Nielsen commented on patch set 2 05/10/23, 08:20

    Reply

    Makes sense. Done
  6. core-ci voted on patch set 2 V +1 05/10/23, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41722

  7. Stefan Froemken commented on patch set 2 CR -1 05/10/23, 19:03

    I'm not a ckeditor PRO, but attaching un-minified JavaScript to a minified js file looks odd. I will remove my vote, if that's really the way to go.
  8. Johannes Nielsen commented on patch set 2 05/11/23, 06:57

    Reply

    Indeed, that doesn't seem right. Honestly I didn't really look at the bundled file because it is generated using `npm run build`. I'll try and fix this.
  9. Johannes Nielsen commented on patch set 2 05/11/23, 07:34

    Reply

    On second thought: The entire file is unminified, not just the lines this patch adds. This seems to be a more general issue with the rollup configuration. It is probably possible to minify this file (I am absolutely no expert on rollup), however I am unsure whether that is within the scope of the issue.
  10. Andreas Kienast commented on patch set 2 05/11/23, 17:38

    Reply

    I didn‘t do any investigations, but solving the „unminified code in the build“ case is IMO not the scope of this patch. You didn‘t fiddle with the build chain and everything behaves fine, otherwise the CI would‘ve gone red. I remember I spotted the same „issue“ when upgrading ckeditor earlier. @Stefan: can you please lift your -1?
  11. Stefan Froemken voted on patch set 2 CR 0 05/11/23, 19:51

  12. Johannes Nielsen commented on patch set 2 CR -1 05/12/23, 06:23

    The patch does not contain the font size plugin which is also mentioned in the issue
  13. Johannes Nielsen uploaded patch set 3 CR -1 V +1 05/12/23, 07:00

  14. Johannes Nielsen commented on patch set 3 05/12/23, 07:00

    Reply

    Done
  15. core-ci voted on patch set 3 V +1 05/12/23, 07:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41771

  16. Chris topher voted on patch set 3 V +1 CR +1 05/12/23, 16:04

  17. Johannes Nielsen commented on patch set 3 06/01/23, 07:09

    Reply

    Done
  18. Andreas Kienast uploaded patch set 4 CR +1 V +1 06/02/23, 08:51

  19. core-ci voted on patch set 4 V +1 06/02/23, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42160

  20. Sybille Peters commented on patch set 4 06/03/23, 09:37

    Must the configuration be changed in any way? In that case, it would be nice if you could add a Changelog (e.g. use type "Important" for a bugfix) and also make the changes in the docs. (Personally, I would rather have it documented in the documentation than in a commit message, but if we previously did not document it and it didn't change, you should be in the clear.).
  21. Johannes Nielsen commented on patch set 4 06/05/23, 08:14

    Reply

    Well, you _can_ adapt the configuration, if you add those plugins to your RTE. Is that what you mean? Honestly, the documentation on RTE configuration seems to be partially outdated anyways. It still references the CKEditor4 documentation (https://docs.typo3.org/c/typo3/cms-rte-ckeditor/main/en-us/Configuration/Reference.html#editor-config) and talks about editor.externalPlugins which is no longer supported. Is there a separate patch addressing this?
  22. Sybille Peters commented on patch set 4 06/05/23, 08:32

    Reply

    My question is if there is any configuration change directly related to this patch which should be addressed in this patch (by changelog oder docs change). Everything else (including updating the docs) can be done in separate patches).
  23. Johannes Nielsen uploaded patch set 5 V +1 06/08/23, 11:39

  24. Johannes Nielsen uploaded patch set 6 06/08/23, 11:46

  25. core-ci voted on patch set 5 V -1 06/08/23, 11:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42299

  26. Johannes Nielsen commented on patch set 6 06/08/23, 11:48

    Reply

    Alright, I added a short changelog entry. Hopefully it is in the right place and contains all the information it should. I think adding this to the docs should be done in a separate patch specifically targeted at updating RTE docs.
  27. core-ci voted on patch set 6 V +1 06/08/23, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42300

  28. Johannes Nielsen commented on patch set 6 06/13/23, 12:17

    Reply

    Done
  29. Chris topher commented on patch set 6 06/22/23, 07:17

    Thanks for adding the documentation! Is there anything else that needs to be done to get this change in?
  30. David Bruchmann commented on patch set 6 09/08/23, 16:04

    Reply

    I think at least one yaml file should get this: table: defaultHeadings: { rows: 1 } contentToolbar: - tableColumn - tableRow - mergeTableCells - tableProperties - tableCellProperties - toggleTableCaption
  31. David Bruchmann commented on patch set 6 09/08/23, 16:14

    Reply

    the other settings should certainly be included in a yaml file too. Concerning TableCaption some further settings concerning the new tag figcaption in TypoScript are required too, here is a walkthrough with all things to get it running completetly: https://forge.typo3.org/issues/101874?next_issue_id=101869.
  32. David Bruchmann commented on patch set 6 09/08/23, 17:41

    ckeditor5-bundle.js:27

    import { Font } from '@ckeditor/ckeditor5-font/src';
  33. David Bruchmann commented on patch set 6 09/08/23, 17:49

    In the rst-file all options should be added correctly. Concerning the font options it's like below. Don't mind about the comments, remove, alter or add as you like: editor: config: toolbar: items: - fontFamily - fontSize - fontColor # add button to select text color - fontBackgroundColor # add button to select text background color
  34. David Bruchmann commented on patch set 6 V -1 CR -1 09/08/23, 17:54

    needs a bit more work like explained before ;-)
  35. David Bruchmann commented on patch set 6 09/08/23, 18:04

    Important-100847-AddPluginsToCKEditor.rst:30

    These lines in the rst file, with empty options, but as comments, might be more confusing than helping, I think. Is there an example how further options are added in those update massages? Else I'd just leave it away.
  36. Benjamin Franzke commented on patch set 6 09/13/23, 06:43

    You can also add `Resolves: #101874` with the next push, since you seem to resolve https://forge.typo3.org/issues/101874 with this as well.

    ckeditor5-bundle.js:27 Reply

  37. Benjamin Franzke uploaded patch set 7 CR -1 V +1 10/04/23, 20:57

  38. Benjamin Franzke commented on patch set 7 10/04/23, 20:57

    Reply

    Done

    Important-100847-AddPluginsToCKEditor.rst:30 Reply

    Done
  39. core-ci voted on patch set 7 V -1 10/04/23, 21:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47410

  40. Benjamin Franzke uploaded patch set 8 V -1 10/05/23, 08:47

  41. core-ci voted on patch set 8 V -1 10/05/23, 09:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47427

  42. Benjamin Franzke uploaded patch set 9 V -1 10/06/23, 08:10

  43. core-ci voted on patch set 9 V -1 10/06/23, 08:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47457

  44. Benjamin Franzke uploaded patch set 10 V -1 10/06/23, 08:50

  45. core-ci voted on patch set 10 V -1 10/06/23, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47463

  46. Benjamin Franzke uploaded patch set 11 V -1 10/06/23, 09:05

  47. Benjamin Franzke uploaded patch set 12 10/06/23, 09:08

  48. core-ci voted on patch set 12 V -1 10/06/23, 09:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47472

  49. Benjamin Franzke rebased onto patch set 13 V -1 10/06/23, 11:51

  50. core-ci voted on patch set 13 V -1 10/06/23, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47483

  51. Benjamin Franzke rebased onto patch set 14 V -1 10/06/23, 12:30

  52. core-ci voted on patch set 14 V -1 10/06/23, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47490

  53. Benjamin Franzke uploaded patch set 15 V -1 10/06/23, 13:13

  54. core-ci voted on patch set 15 V -1 10/06/23, 13:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47496

  55. Benjamin Franzke uploaded patch set 16 V -1 10/06/23, 14:35

  56. core-ci voted on patch set 16 V -1 10/06/23, 14:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47504

  57. Benjamin Franzke rebased onto patch set 17 V -1 10/06/23, 14:52

  58. core-ci voted on patch set 17 V +1 10/06/23, 15:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47507

  59. Benjamin Franzke rebased onto patch set 18 V +1 10/06/23, 16:19

  60. core-ci voted on patch set 18 V +1 10/06/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47514

  61. Benjamin Franzke uploaded patch set 19 V +1 10/08/23, 04:07

  62. Benjamin Franzke voted on patch set 19 V +1 CR +1 10/08/23, 04:07

  63. core-ci voted on patch set 19 V +1 10/08/23, 04:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47550

  64. Benjamin Franzke uploaded patch set 20 CR +1 V +1 10/08/23, 04:39

  65. Benjamin Franzke commented on patch set 20 10/08/23, 04:40

    Reply

    Added to Full.ymml and fixed the default frontend config to allow figcaption to be rendered.
  66. David Bruchmann commented on patch set 20 10/08/23, 04:51

    Reply

    Great that you're so busy on it! What you think about adding the new font options to full.yaml too?
  67. core-ci voted on patch set 20 V +1 10/08/23, 04:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47552

  68. Benjamin Franzke uploaded patch set 21 V +1 10/08/23, 05:35

  69. Benjamin Franzke commented on patch set 21 V +1 CR +1 10/08/23, 05:36

    Reply

    ACK (since it was included in v11 Full as well). Also fixed some other cases I recently broke for "Full".
  70. core-ci voted on patch set 21 V +1 10/08/23, 05:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47553

  71. Benjamin Franzke uploaded patch set 22 CR +1 V +1 10/09/23, 05:17

  72. core-ci voted on patch set 22 V +1 10/09/23, 05:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47587

  73. Benjamin Franzke marked it work in progress 10/09/23, 15:51

  74. Benjamin Franzke marked it ready for review 10/10/23, 05:39

  75. Benjamin Franzke rebased onto patch set 23 V +1 10/10/23, 05:39

  76. core-ci voted on patch set 23 V +1 10/10/23, 05:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47635

  77. Benjamin Franzke voted on patch set 23 V +1 CR +1 10/10/23, 07:23

  78. Oliver Hader voted on patch set 23 CR +1 10/10/23, 08:01

  1. Oliver Hader voted on patch set 23 V +1 10/10/23, 08:26

  2. Benjamin Franzke marked it work in progress 10/10/23, 18:49

  3. Sybille Peters wrote 10/26/23, 18:20

    Removed cc Sybille Peters.
  4. Benjamin Franzke uploaded patch set 24 CR +1 V +1 12/14/23, 08:19

  5. Benjamin Franzke marked it ready for review 12/14/23, 08:23

  6. core-ci voted on patch set 24 V +1 12/14/23, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50639

  7. Benjamin Franzke uploaded patch set 25 V +1 12/14/23, 08:45

  8. core-ci voted on patch set 25 V +1 12/14/23, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50643

  9. David Bruchmann commented on patch set 25 12/14/23, 09:17

    Full.yaml:97

    Like commented in https://review.typo3.org/c/Packages/TYPO3.CMS/+/81397 "toggleTableCaption" isn't found without adding ` - { 'module': '@ckeditor/ckeditor5-table', exports: ['Table', 'TableToolbar', 'TableProperties', 'TableCellProperties', 'TableCaption'] }` I tested with v12.4.9
  10. David Bruchmann commented on patch set 25 12/14/23, 09:30

    Full.yaml:97 Reply

    It might be though that I'm mistaking as I didn't test it like included in the system extensions but copied the JS files to the sitepackage and adjusted the Configuration/JavaScriptModules,php. So sorry if this leads to confusion.
  11. Benjamin Franzke commented on patch set 25 12/14/23, 09:31

    Full.yaml:97 Reply

    That is included in Build/Sources/TypeScript/rte_ckeditor/ckeditor5.ts and I moved that piece to another patch: 82185: [TASK] Enable tablecaption in CKEditor5 | https://review.typo3.org/c/Packages/TYPO3.CMS/+/82185
  12. Benjamin Franzke uploaded patch set 26 V +1 02/12/24, 20:45

  13. core-ci voted on patch set 26 V +1 02/12/24, 20:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53103

  14. Guido Schmechel commented on patch set 26 02/16/24, 13:13

    I am aware that something will happen here. But here is some feedback on the documentation :-)

    Important-100847-AddedFontPluginToCKEditor5.rst:14

    Does it make sense to link the official documentation? Example: https://ckeditor.com/docs/ckeditor5/latest/features/font.html

    Important-100847-AddedFontPluginToCKEditor5.rst:19

    I had tested a little. What I was missing here: importModules: - { 'module': '@ckeditor/ckeditor5-font', 'exports': ['Font'] } It seemed as if I only had to add these options (fontColor+fontBackgroundColor).

    Important-100847-AddedFontPluginToCKEditor5.rst:31

    label instead of name? The hex code was displayed here. Only after changing the config to "label" the value "orange" was shown when hovering.
  15. Benjamin Franzke uploaded patch set 27 V +1 02/17/24, 08:18

  16. core-ci voted on patch set 27 V +1 02/17/24, 08:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53268

  17. Benjamin Franzke uploaded patch set 28 V +1 02/17/24, 08:35

  18. Benjamin Franzke commented on patch set 28 02/17/24, 08:35

    Important-100847-AddedFontPluginToCKEditor5.rst:14 Reply

    Done

    Important-100847-AddedFontPluginToCKEditor5.rst:19 Reply

    Ack, good catch. Added.

    Important-100847-AddedFontPluginToCKEditor5.rst:31 Reply

    Thanks, done!
  19. core-ci voted on patch set 28 V +1 02/17/24, 08:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/53269

  20. Torben Hansen voted on patch set 28 CR +1 V +1 02/17/24, 08:46

  21. Guido Schmechel voted on patch set 28 CR +1 V +1 02/17/24, 10:34

  22. David Bruchmann voted on patch set 28 CR +1 V +1 02/18/24, 08:23

  23. Benni Mack voted on patch set 28 CR +1 V +1 02/18/24, 21:57

  24. Benjamin Franzke voted on patch set 28 CR +2 V +2 02/19/24, 04:40

  25. Benjamin Franzke merged patch set 29 02/19/24, 04:47