Review main Merged

79007[BUGFIX] Properly hide overlay in form engine after translating

Georg Ringer CR +2 V +2 Easy +2 −2 updated 07/05/23, 20:50

Commit message

If a record is translated, the modal overlay is now closed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 3

Files 2

Review log 1521

  1. Georg Ringer uploaded patch set 1 05/10/23, 07:08

  2. Georg Ringer commented on patch set 1 05/10/23, 07:09

    This change is ready for review.
  3. Andreas Kienast commented on patch set 1 05/10/23, 07:11

    form-engine.ts:743

    I think we can remove this condition entirely. `input` cannot be `undefined` here, it's always `HTMLInputElement|null`.
  4. core-ci voted on patch set 1 V +1 05/10/23, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41719

  5. Oli Bartsch commented on patch set 1 05/10/23, 07:56

    form-engine.ts:743 Reply

    Actually input can be undefined. This is the reported error in the console: "Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'disabled')" Tested with console.log(null?.querySelector('*')); // undefined
  6. Andreas Kienast commented on patch set 1 05/10/23, 08:40

    form-engine.ts:743 Reply

    You're right, I overlooked the `?.` selector.
  7. Georg Ringer rebased onto patch set 2 V +1 05/15/23, 12:27

  8. core-ci voted on patch set 2 V +1 05/15/23, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41835

  9. Georg Ringer rebased onto patch set 3 V +1 06/30/23, 17:18

  10. core-ci voted on patch set 3 V +1 06/30/23, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43159

  11. Helmut Hummel commented on patch set 3 V +1 CR +1 06/30/23, 17:33

    form-engine.ts:743 Reply

    does the forced cast make sense then? Shouldn't TS know what types can be resolved from DOM Api?
  12. Andreas Kienast updated the commit message in patch set 4 CR +1 V +1 07/05/23, 11:58

  13. Andreas Kienast commented on patch set 4 V +1 CR +1 07/05/23, 11:58

    form-engine.ts:743 Reply

    Nope, TS knows that `querySelector()` returns an instance of `Element`, nothing more or less.
  14. core-ci voted on patch set 4 V -1 07/05/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43499

  15. core-ci voted on patch set 4 V +1 07/05/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43499

  16. Susi Moog voted on patch set 4 V +1 CR +1 07/05/23, 14:24

  17. Susi Moog updated the commit message in patch set 5 CR +1 V +1 07/05/23, 20:21

  18. Susi Moog voted on patch set 5 V +1 CR +1 07/05/23, 20:21

  19. core-ci voted on patch set 5 V +1 07/05/23, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43618

  20. Benni Mack voted on patch set 5 V +2 CR +2 07/05/23, 20:50

  21. Benni Mack merged patch set 6 07/05/23, 20:50