79007[BUGFIX] Properly hide overlay in form engine after translating
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 3
Files 2
Review log 1521
-
Georg Ringer uploaded patch set 1 05/10/23, 07:08
-
Georg Ringer commented on patch set 1 05/10/23, 07:09
This change is ready for review. -
Andreas Kienast commented on patch set 1 05/10/23, 07:11
form-engine.ts:743I think we can remove this condition entirely. `input` cannot be `undefined` here, it's always `HTMLInputElement|null`. -
core-ci voted on patch set 1 V +1 05/10/23, 07:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41719
-
Oli Bartsch commented on patch set 1 05/10/23, 07:56
form-engine.ts:743ReplyActually input can be undefined. This is the reported error in the console: "Uncaught (in promise) TypeError: Cannot set properties of undefined (setting 'disabled')" Tested with console.log(null?.querySelector('*')); // undefined -
Andreas Kienast commented on patch set 1 05/10/23, 08:40
form-engine.ts:743ReplyYou're right, I overlooked the `?.` selector. -
Georg Ringer rebased onto patch set 2
V +105/15/23, 12:27 -
core-ci voted on patch set 2 V +1 05/15/23, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41835
-
Georg Ringer rebased onto patch set 3
V +106/30/23, 17:18 -
core-ci voted on patch set 3 V +1 06/30/23, 17:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43159
-
Helmut Hummel commented on patch set 3 V +1 CR +1 06/30/23, 17:33
form-engine.ts:743Replydoes the forced cast make sense then? Shouldn't TS know what types can be resolved from DOM Api? -
Andreas Kienast updated the commit message in patch set 4
CR +1V +107/05/23, 11:58 -
Andreas Kienast commented on patch set 4 V +1 CR +1 07/05/23, 11:58
form-engine.ts:743ReplyNope, TS knows that `querySelector()` returns an instance of `Element`, nothing more or less. -
core-ci voted on patch set 4 V -1 07/05/23, 12:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43499
-
core-ci voted on patch set 4 V +1 07/05/23, 12:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43499
-
Susi Moog voted on patch set 4 V +1 CR +1 07/05/23, 14:24
-
Susi Moog updated the commit message in patch set 5
CR +1V +107/05/23, 20:21 -
Susi Moog voted on patch set 5 V +1 CR +1 07/05/23, 20:21
-
core-ci voted on patch set 5 V +1 07/05/23, 20:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43618
-
Benni Mack voted on patch set 5 V +2 CR +2 07/05/23, 20:50
-
Benni Mack merged patch set 6 07/05/23, 20:50