Review main Merged

79015[TASK] Allow to configure CKEditor "General HTML Support" plugin

Torben Hansen CR +2 V +2 Easy +5 −1 updated 09/15/23, 12:10

Commit message

The CKEditor 5 build for TYPO3 contains the "General HTML Support"
plugin. It is however not possible to configure the plugin, since
the `htmlSupport` configuration key is not added to the CKEditor
configuration.

With this patch, the `htmlSupport` configuration key is passed
through to the general CKEditor configuration.

See https://ckeditor.com/docs/ckeditor5/latest/features/html/general-html-support.html

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1318

  1. Torben Hansen uploaded patch set 1 05/11/23, 17:37

  2. core-ci voted on patch set 1 V -1 05/11/23, 17:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41759

  3. Torben Hansen uploaded patch set 2 V -1 05/12/23, 05:40

  4. core-ci voted on patch set 2 V +1 05/12/23, 05:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41770

  5. Oliver Hader updated the commit message in patch set 3 V +1 05/16/23, 08:24

  6. Oliver Hader voted on patch set 3 CR +1 05/16/23, 08:25

  7. core-ci voted on patch set 3 V +1 05/16/23, 08:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41863

  8. Georg Ringer voted on patch set 3 V +1 CR +1 05/17/23, 13:28

  9. Jörg Bösche voted on patch set 3 CR +1 05/26/23, 13:14

  10. Oliver Klee commented on patch set 3 07/24/23, 14:14

    This change needs a rebase.
  11. Torben Hansen uploaded patch set 4 CR +1 V +1 07/24/23, 16:51

  12. core-ci voted on patch set 4 V +1 07/24/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44484

  13. Benjamin Franzke uploaded patch set 5 V +1 09/15/23, 11:57

  14. Benjamin Franzke voted on patch set 5 V +1 CR +1 09/15/23, 11:57

  15. Benjamin Kott voted on patch set 5 V +1 CR +1 09/15/23, 12:01

  16. Benjamin Franzke voted on patch set 5 V +2 CR +2 09/15/23, 12:01

  17. core-ci voted on patch set 5 V +1 09/15/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46606

  18. Benjamin Franzke merged patch set 6 09/15/23, 12:10