Review main Merged

79024[BUGFIX] Fix alignment of fields in Active TypoScript module

Andreas Nedbal CR +2 V +2 Easy +1 −1 updated 06/07/23, 11:57

Commit message

If multiple TypoScript templates are present the label creates
an offset with the rest of the option controls. Aligning all
controls to the bottom of the container fixes this.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1315

  1. Andreas Nedbal uploaded patch set 1 05/13/23, 00:42

  2. core-ci voted on patch set 1 V +1 05/13/23, 00:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41787

  3. Oliver Klee voted on patch set 1 CR +1 05/13/23, 08:18

  4. Daniel Haupt voted on patch set 1 V +1 CR +1 05/13/23, 09:37

  5. Stefan Bürk commented on patch set 1 05/15/23, 20:05

    ActiveOptions.html:7

    Not sure, not an CSS people. But shouldn't this be `align-items-end-md` to math the `form-row-*` setting ?
  6. Andreas Nedbal uploaded patch set 2 CR +1 V +1 05/15/23, 21:51

  7. Andreas Nedbal commented on patch set 2 05/15/23, 21:52

    ActiveOptions.html:7 Reply

    Done
  8. core-ci voted on patch set 2 V +1 05/15/23, 21:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41855

  9. Torben Hansen voted on patch set 2 V +1 CR +1 05/17/23, 09:06

  10. Oliver Klee voted on patch set 2 CR +1 05/17/23, 10:57

  11. Jasmina Ließmann voted on patch set 2 V +1 CR +1 06/07/23, 09:09

  12. Benni Mack voted on patch set 2 CR -2 06/07/23, 11:25

  13. Benni Mack voted on patch set 2 CR 0 06/07/23, 11:56

  14. Jasmina Ließmann voted on patch set 2 V +2 CR +2 06/07/23, 11:57

  15. Jasmina Ließmann merged patch set 3 06/07/23, 11:57