Review main Merged

79026[TASK] Include and load CKEditor locales if configured

Andreas Nedbal CR +2 V +2 Hard +269 −2 updated 07/05/23, 21:00

Commit message

This patch adds support for loading the base CKEditor 5
locales and importing them in the backend if requested.

Because CKEditor doesn't ship a full set of locales, we
needed to add an additional build step that assembles
the locales of all plugins we have installed.

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Torben Hansen +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Torben Hansen +1
    • Andreas Kienast +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 79

Show 59 more files

Review log 1622

  1. Andreas Nedbal uploaded patch set 1 05/14/23, 01:20

  2. Andreas Nedbal uploaded patch set 2 05/14/23, 01:21

  3. core-ci voted on patch set 2 V +1 05/14/23, 01:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41802

  4. core-ci voted on patch set 1 V -1 05/14/23, 01:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41801

  5. Andreas Nedbal uploaded patch set 3 V +1 05/14/23, 14:59

  6. Andreas Nedbal updated the commit message in patch set 4 05/14/23, 15:05

  7. core-ci voted on patch set 3 V +1 05/14/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41822

  8. core-ci voted on patch set 4 V +1 05/14/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41823

  9. Torben Hansen commented on patch set 4 V +1 05/20/23, 10:45

    The patch in general looks good to me and works as expected. Note, that #100633 is required to test the patch, since CKEditor currently does not respects the backend users language. Adding Andy and Olly to CC
  10. Oliver Hader voted on patch set 4 CR +1 07/03/23, 09:46

  11. Andreas Kienast commented on patch set 4 07/05/23, 18:21

    package.json:64

    Please fix the indentation

    RichTextElement.php:191

    Does this mean I have to configure this explictly? I've set my backend language to German and can't notice any difference in my ckeditor instances.
  12. Andreas Nedbal rebased onto patch set 5 CR +1 V +1 07/05/23, 18:40

  13. Andreas Nedbal uploaded patch set 6 07/05/23, 18:49

  14. Andreas Nedbal commented on patch set 6 07/05/23, 18:49

    package.json:64 Reply

    Done

    RichTextElement.php:191 Reply

    Done. I should have done a rebase. This patch required #100633 because the CKEditor config at that point included language overrides which made the backend user language never apply.
  15. Andreas Kienast voted on patch set 6 V +1 CR +1 07/05/23, 18:54

  16. core-ci voted on patch set 5 V -1 07/05/23, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43588

  17. core-ci voted on patch set 6 V +1 07/05/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43592

  18. Oliver Hader voted on patch set 6 CR +1 07/05/23, 19:34

  19. Torben Hansen voted on patch set 6 V +1 CR +1 07/05/23, 19:36

  20. Oliver Hader voted on patch set 6 V +1 07/05/23, 19:53

  21. Andreas Nedbal voted on patch set 6 V +2 CR +2 07/05/23, 21:00

  22. Andreas Nedbal merged patch set 7 07/05/23, 21:00