79026[TASK] Include and load CKEditor locales if configured
Commit message
Review
-
Code review CR +2 Done
- Andreas Nedbal +2
- Torben Hansen +1
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Andreas Nedbal +2
- Torben Hansen +1
- Andreas Kienast +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 79
- Build/Scripts/node/ckeditor-locale-compiler.jsnew+146 −0
- Build/ckeditor5.rollup.config.js+3 −1
- Build/ckeditor5.rollup.helpers.jsnew+25 −0
- Build/Gruntfile.js+5 −1
- Build/package-lock.json+1 −0
- Build/package.json2+1 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php2+16 −0
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/af.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ar.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ast.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/az.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bg.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bn.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/bs.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ca.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/cs.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/da.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de-ch.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/de.jsnew+1 −0
Show 59 more files
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/el.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-au.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en-gb.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/en.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eo.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es-co.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/es.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/et.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/eu.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fa.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fi.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/fr.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gl.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/gu.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/he.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hi.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hr.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/hu.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/id.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/it.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ja.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/jv.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kk.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/km.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/kn.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ko.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ku.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lt.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/lv.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ms.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nb.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ne.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/nl.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/no.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/oc.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pl.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt-br.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/pt.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ro.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ru.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/si.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sk.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sl.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sq.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr-latn.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sr.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/sv.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/th.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tk.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tr.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/tt.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ug.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uk.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/ur.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/uz.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/vi.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh-cn.jsnew+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/translations/zh.jsnew+1 −0
- .gitignore+1 −0
Review log 1622
-
Andreas Nedbal uploaded patch set 1 05/14/23, 01:20
-
Andreas Nedbal uploaded patch set 2 05/14/23, 01:21
-
core-ci voted on patch set 2 V +1 05/14/23, 01:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41802
-
core-ci voted on patch set 1 V -1 05/14/23, 01:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41801
-
Andreas Nedbal uploaded patch set 3
V +105/14/23, 14:59 -
Andreas Nedbal updated the commit message in patch set 4 05/14/23, 15:05
-
core-ci voted on patch set 3 V +1 05/14/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41822
-
core-ci voted on patch set 4 V +1 05/14/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41823
-
Torben Hansen commented on patch set 4 V +1 05/20/23, 10:45
The patch in general looks good to me and works as expected. Note, that #100633 is required to test the patch, since CKEditor currently does not respects the backend users language. Adding Andy and Olly to CC -
Oliver Hader voted on patch set 4 CR +1 07/03/23, 09:46
-
Andreas Kienast commented on patch set 4 07/05/23, 18:21
package.json:64Please fix the indentationRichTextElement.php:191Does this mean I have to configure this explictly? I've set my backend language to German and can't notice any difference in my ckeditor instances. -
Andreas Nedbal rebased onto patch set 5
CR +1V +107/05/23, 18:40 -
Andreas Nedbal uploaded patch set 6 07/05/23, 18:49
-
Andreas Nedbal commented on patch set 6 07/05/23, 18:49
package.json:64ReplyDoneRichTextElement.php:191ReplyDone. I should have done a rebase. This patch required #100633 because the CKEditor config at that point included language overrides which made the backend user language never apply. -
Andreas Kienast voted on patch set 6 V +1 CR +1 07/05/23, 18:54
-
core-ci voted on patch set 5 V -1 07/05/23, 18:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43588
-
core-ci voted on patch set 6 V +1 07/05/23, 19:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43592
-
Oliver Hader voted on patch set 6 CR +1 07/05/23, 19:34
-
Torben Hansen voted on patch set 6 V +1 CR +1 07/05/23, 19:36
-
Oliver Hader voted on patch set 6 V +1 07/05/23, 19:53
-
Andreas Nedbal voted on patch set 6 V +2 CR +2 07/05/23, 21:00
-
Andreas Nedbal merged patch set 7 07/05/23, 21:00