79027[BUGFIX] Add `ESCAPE` keyword for `like()` and `notLike() expressions
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Stefan Froemken +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- Stefan Froemken +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Database/Query/Expression/ExpressionBuilder.php+4 −2
- typo3/sysext/core/Tests/Functional/Database/Fixtures/DataSet/TestExpressionBuilderLikeAndNotLike.csv2+3 −0
- typo3/sysext/core/Tests/Functional/Database/Query/Expression/ExpressionBuilderTest.php+124 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Expression/ExpressionBuilderTest.php2+8 −2
- typo3/sysext/indexed_search/Tests/Functional/Utility/LikeWildcardTest.php+3 −0
Review log 2032
Show 47 earlier messages
-
Stefan Bürk uploaded patch set 1 05/14/23, 02:17
-
core-ci voted on patch set 1 V -1 05/14/23, 02:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41804
-
Stefan Bürk uploaded patch set 2
V -105/14/23, 02:45 -
core-ci voted on patch set 2 V -1 05/14/23, 02:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41805
-
Stefan Bürk uploaded patch set 3
V -105/14/23, 03:01 -
core-ci voted on patch set 3 V -1 05/14/23, 03:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41806
-
Stefan Bürk uploaded patch set 4
V -105/14/23, 03:37
-
core-ci voted on patch set 4 V -1 05/14/23, 03:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41808
-
Stefan Bürk updated the commit message in patch set 5
V -105/14/23, 03:56 -
core-ci voted on patch set 5 V -1 05/14/23, 04:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41809
-
Stefan Bürk uploaded patch set 6
V -105/14/23, 04:18 -
core-ci voted on patch set 6 V +1 05/14/23, 04:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41812
-
Stefan Bürk updated the commit message in patch set 7
V +105/14/23, 04:28 -
core-ci voted on patch set 7 V +1 05/14/23, 04:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41813
-
Stefan Bürk commented on patch set 7 05/14/23, 04:38
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/41814 -
core-ci commented on patch set 7 05/14/23, 05:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41814
-
Benni Mack updated the commit message in patch set 8
V +105/15/23, 20:30 -
Benni Mack voted on patch set 8 CR +1 05/15/23, 20:30
-
core-ci voted on patch set 8 V +1 05/15/23, 20:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41854
-
Christian Kuhn updated the commit message in patch set 9
CR +1V +106/08/23, 15:00 -
Christian Kuhn rebased onto patch set 10 06/08/23, 15:00
-
core-ci voted on patch set 9 V +1 06/08/23, 15:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42313
-
core-ci voted on patch set 10 V +1 06/08/23, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42314
-
Christian Kuhn voted on patch set 10 V +1 CR +1 06/08/23, 15:19
-
Stefan Froemken commented on patch set 10 06/12/23, 06:55
TestExpressionBuilderLikeAndNotLike.csv:7Just a nice to have: Can you also add a test for "%"?ExpressionBuilderTest.php:182Is that correct? We are in a text with double quotes. IMO there is no need to quote characters with backslash like in single quoted texts. -
Stefan Bürk uploaded patch set 11
CR +1V +106/12/23, 11:27 -
Stefan Bürk commented on patch set 10 06/12/23, 11:29
TestExpressionBuilderLikeAndNotLike.csv:7ReplyDoneExpressionBuilderTest.php:182ReplyThe point is, that the generated SQL syntax is: ``` ESCAPE "\" ``` So, the double-quotes must be escaped. You are right, normally a backslahs does not need to be escaped .. but a backslash before a escaped quote needs it. IMO thats the correct test for it. -
core-ci voted on patch set 11 V +1 06/12/23, 11:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42383
-
Christian Kuhn voted on patch set 11 V +1 CR +1 06/12/23, 13:56
-
Stefan Froemken voted on patch set 11 V +1 CR +1 06/12/23, 20:24
-
Stefan Bürk voted on patch set 11 V +2 CR +2 06/12/23, 21:35
-
Stefan Bürk merged patch set 12 06/12/23, 21:35