Review main Merged

79030[BUGFIX] Strip superfluous srcset path prefix

Manuel Glauser CR +2 V +2 Easy +5 −2 updated 07/04/23, 17:31

Commit message

Rendering image '<source>' elements using the
IMAGE content object (layoutKey 'picture')
no longer have the document root path prepended
in the 'srcset' attribute.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Robinson +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 812

  1. Manuel Glauser uploaded patch set 1 05/14/23, 20:08

  2. core-ci voted on patch set 1 V -1 05/14/23, 20:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41824

  3. Manuel Glauser uploaded patch set 2 V -1 05/15/23, 06:37

  4. core-ci voted on patch set 2 V -1 05/15/23, 06:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41830

  5. core-ci voted on patch set 1 V -1 05/15/23, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41824

  6. Stefan Bürk rebased onto patch set 3 V -1 05/15/23, 07:36

  7. core-ci voted on patch set 3 V +1 05/15/23, 07:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41831

  8. Benjamin Robinson commented on patch set 3 V +1 05/15/23, 11:48

    I am not experienced enough to evaluate the code, but I can confirm that the patch works.
  9. Benni Mack voted on patch set 3 CR +1 07/04/23, 07:35

  10. Benni Mack voted on patch set 3 V +1 07/04/23, 10:38

  11. Stefan Bürk voted on patch set 3 V +2 CR +2 07/04/23, 17:31

  12. Stefan Bürk merged patch set 4 07/04/23, 17:31