Review main Merged

79053[DOCS] Add SQL and memory metrics to admin panel toolbar

Chris Müller CR +2 V +2 Easy +14 −4 updated 05/26/23, 06:52

Commit message

The new metrics about SQL and memory are added to the admin panel documentation.

Additionally, some screenshots are adjusted for v12.4.

Review

  • Code review CR +2 Done
    • Lina Wolf +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Lina Wolf +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 6

Review log 911

  1. Chris Müller uploaded patch set 1 05/16/23, 07:15

  2. core-ci voted on patch set 1 V +1 05/16/23, 07:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41862

  3. Georg Ringer voted on patch set 1 V +1 CR +1 05/16/23, 07:27

  4. Christoph Lehmann commented on patch set 1 05/16/23, 15:12

    We could add a note (no blocker), that the amount of SQL queries misses round about 20 Boot-Queries (Queries before logging is enabled)
  5. Chris Müller commented on patch set 1 05/16/23, 16:14

    Reply

    Best place would be here, I think: https://docs.typo3.org/c/typo3/cms-adminpanel/12.4/en-us/Inspecting/Debug/Index.html#query-information Do you want to add the note? Maybe also in a separate PR as this is not really related to this one. What kind of queries are these?
  6. Chris Müller uploaded patch set 2 CR +1 V +1 05/18/23, 16:03

  7. core-ci voted on patch set 2 V +1 05/18/23, 16:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41906

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 05/25/23, 03:48

  9. Lina Wolf voted on patch set 2 CR +2 05/26/23, 06:51

  10. Lina Wolf voted on patch set 2 V +2 05/26/23, 06:52

  11. Lina Wolf merged patch set 3 05/26/23, 06:52