Review main Merged

79058[BUGFIX] Inject CSP nonce values only if CSP feature is enabled

Oliver Hader CR +2 V +2 Easy +7 −5 updated 05/17/23, 05:55

Commit message

Currently, CSP nonce values are used per default during the frontend
rendering process (which basically would be fine). However, this also
leads to the situation, that the page is not considered to be fully
cached anymore (`INTincScript`).

With this change, CSP nonce values are only used if the corresponding
CSP feature is enabled for the frontend scope.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 69

  1. Oliver Hader uploaded patch set 1 05/16/23, 13:56

  2. Oliver Hader uploaded patch set 2 05/16/23, 14:01

  3. core-ci voted on patch set 1 V +1 05/16/23, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41868

  4. core-ci voted on patch set 2 V -1 05/16/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41869

  5. Oliver Hader uploaded patch set 3 V -1 05/16/23, 14:27

  6. core-ci voted on patch set 3 V +1 05/16/23, 14:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41870

  7. Torben Hansen voted on patch set 3 V +1 CR +1 05/16/23, 16:04

  8. Georg Ringer voted on patch set 3 V +2 CR +2 05/17/23, 05:54

  9. Georg Ringer merged patch set 4 05/17/23, 05:55