Review main Merged

79059[BUGFIX] Fix undefined array key in FrontendGenerationPageIndexingTrigger

Nikita Hovratov CR +2 V +2 Easy +1 −1 updated 05/19/23, 07:15

Commit message

This is an edge-case, where `config.index_enable = 1` is set, but the
static TypoScript from indexed_search is not included and thus
`config.index_externals` is undefined.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Georg Ringer +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Nikita Hovratov uploaded patch set 1 05/16/23, 14:38

  2. core-ci voted on patch set 1 V +1 05/16/23, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41871

  3. Oliver Klee voted on patch set 1 CR +1 05/16/23, 14:51

  4. Georg Ringer voted on patch set 1 V +1 CR +1 05/17/23, 06:07

  5. Benni Mack voted on patch set 1 CR +1 05/17/23, 07:35

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 05/18/23, 15:34

  7. Stefan Bürk voted on patch set 1 V +1 CR +1 05/18/23, 19:28

  8. Nikita Hovratov voted on patch set 1 V +2 CR +2 05/19/23, 07:15

  9. Nikita Hovratov merged patch set 2 05/19/23, 07:15