79063[BUGFIX] Render image processing results in install tool
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 1
Review log 78
-
Daniel Siepmann uploaded patch set 1 05/17/23, 11:27
-
Daniel Siepmann commented on patch set 1 05/17/23, 11:28
I'm not suer what "success" should communicate. I'm not sure whether that is the proper approach. Maybe we should remove the success flag and the corresponding check within TypeScript? -
core-ci voted on patch set 1 V +1 05/17/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41889
-
Daniel Siepmann commented on patch set 1 05/17/23, 11:43
Reply
I could trace back history untilb https://github.com/TYPO3/typo3/commit/eb7539b6897e1a0b1199ebf79fe1804539d8c013#diff-e13975cef0bc1d90f45109d99ac56c805555f88ef2ab0881891831cae8f8ab40R75 and am unable to answer the question myself. -
Benni Mack voted on patch set 1 CR +1 07/04/23, 13:44
-
Susi Moog commented on patch set 1 V +1 CR +1 07/04/23, 14:22
success in this case communicates that the request did what it intended to do and is done ("done" would be a better name) - even if the test in this case is not successful, the request itself was, that's why setting it to true is correct (in other places, success=false will trigger re-requesting the ajax request until success true is returned). -
Benni Mack voted on patch set 1 V +2 CR +2 07/04/23, 14:47
-
Benni Mack merged patch set 2 07/04/23, 14:47