Review main Merged

79063[BUGFIX] Render image processing results in install tool

Daniel Siepmann CR +2 V +2 Easy +13 −0 updated 07/04/23, 14:47

Commit message

Some checks might return a message why images can't be generated.
Those checks didn't return success which prevents processing by
JavaScript, leading to endless "Loading" state within UI.
All responses now properly return success = true in order to be
processed by JavaScript.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Siepmann uploaded patch set 1 05/17/23, 11:27

  2. Daniel Siepmann commented on patch set 1 05/17/23, 11:28

    I'm not suer what "success" should communicate. I'm not sure whether that is the proper approach. Maybe we should remove the success flag and the corresponding check within TypeScript?
  3. core-ci voted on patch set 1 V +1 05/17/23, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41889

  4. Daniel Siepmann commented on patch set 1 05/17/23, 11:43

  5. Benni Mack voted on patch set 1 CR +1 07/04/23, 13:44

  6. Susi Moog commented on patch set 1 V +1 CR +1 07/04/23, 14:22

    success in this case communicates that the request did what it intended to do and is done ("done" would be a better name) - even if the test in this case is not successful, the request itself was, that's why setting it to true is correct (in other places, success=false will trigger re-requesting the ajax request until success true is returned).
  7. Benni Mack voted on patch set 1 V +2 CR +2 07/04/23, 14:47

  8. Benni Mack merged patch set 2 07/04/23, 14:47