79064[BUGFIX] Forward server request object to Fluid view
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Oliver Klee +1
- Stephan Großberndt +1
- Torben Hansen +1
- Jörg Bösche +1
-
Verified V +2 Done
- Oliver Hader +2
- Georg Ringer +1
- Stephan Großberndt +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2023
-
Georg Ringer uploaded patch set 1 05/17/23, 13:37
-
Georg Ringer commented on patch set 1 05/17/23, 13:37
This change is ready for review. -
core-ci voted on patch set 1 V +1 05/17/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41890
-
Oliver Klee voted on patch set 1 CR +1 05/17/23, 13:53
-
Oliver Hader commented on patch set 1 05/17/23, 13:56
PasswordRecovery.html:13`-> f:transform.html() -> f:sanitize.html()` -
Oliver Hader voted on patch set 1 CR -1 05/17/23, 13:56
-
Oliver Hader commented on patch set 1 05/17/23, 14:06
Since issue #100637 any `f:format.html` invocation without Extbase context is broken. For instance FluidEmail cannot be used with that view helper anymore. I think it requires a more generic solution than adjusting every Fluid template. -
Oliver Hader commented on patch set 1 05/17/23, 14:07
Lolli, could you please have a look? Thanks in advance! -
Oliver Hader commented on patch set 1 05/17/23, 14:31
Seems like `\TYPO3\CMS\Core\Mail\FluidEmail::setRequest` would have to forward the request to `$this->view` as well. Thus, no change in templates required for this particular issue. -
Oliver Hader uploaded patch set 2
CR +1V +105/17/23, 16:51 -
Oliver Hader commented on patch set 2 05/17/23, 16:52
Reply
DoneReply
DonePasswordRecovery.html:13ReplyDone -
Oliver Hader uploaded patch set 3 05/17/23, 16:58
-
core-ci voted on patch set 2 V +1 05/17/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41896
-
Oliver Klee voted on patch set 3 CR +1 05/17/23, 17:03
-
core-ci voted on patch set 3 V +1 05/17/23, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41897
-
Christian Kuhn commented on patch set 3 05/18/23, 15:25
fine with me, but i'd love to see an additional @todo in COR as commented.FluidEmail.php:101+1ContentObjectRenderer.php:419It would be better if we could avoid this. In case this is really needed at the moment, it should receive an @todo to review if we could make this non-nullable during v13 development. -
Oliver Hader commented on patch set 3 05/19/23, 10:54
ContentObjectRenderer.php:419ReplyWell, the `$request` class property is nullable. And as long as the request is not enforced e.g. a constructor or a central setter (like done for loggers), I don't see any other chances. Thus, I'll keep it like that. -
Torben Hansen voted on patch set 3 CR +1 05/20/23, 09:53
-
Jörg Bösche voted on patch set 3 CR +1 05/26/23, 13:07
-
Stephan Großberndt commented on patch set 3 V +1 CR +1 06/05/23, 11:38
This is also broken when requesting a password reset link in EXT:fe_login. Would be nice to get this merged rather soon. -
Georg Ringer voted on patch set 3 V +1 CR +1 06/05/23, 12:54
-
Oliver Hader voted on patch set 3 V +2 CR +2 06/05/23, 13:51
-
Oliver Hader merged patch set 4 06/05/23, 13:51