Review main Merged

79066[BUGFIX] Remove correct indexed_search entries on cache clearing

Georg Ringer CR +2 V +2 Easy +3 −7 updated 07/19/23, 08:19

Commit message

Just clear potential the page being edited from indexed_search's
index. The previous implementation did also take potential child
pages, into account, but not the page itself.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1014

  1. Georg Ringer uploaded patch set 1 05/17/23, 14:05

  2. Georg Ringer commented on patch set 1 05/17/23, 14:05

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 05/17/23, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41892

  4. Georg Ringer uploaded patch set 2 V -1 05/17/23, 14:30

  5. core-ci voted on patch set 2 V +1 05/17/23, 14:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41893

  6. Christian Kuhn commented on patch set 2 05/18/23, 15:28

    good to see progress in this area: the indexed_search cache flush DH hook is a serious performance hog that consumes tons and tons of queries, especially with DH bulk operations. this patch is probably only the tip of the iceberg.
  7. Torben Hansen voted on patch set 2 CR +1 05/20/23, 10:00

  8. Christian Kuhn uploaded patch set 3 CR +1 V +1 07/19/23, 06:51

  9. core-ci voted on patch set 3 V +1 07/19/23, 06:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44291

  10. Stefan Bürk updated the commit message in patch set 4 V +1 07/19/23, 08:08

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 07/19/23, 08:08

  12. core-ci voted on patch set 4 V +1 07/19/23, 08:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44292

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 07/19/23, 08:19

  14. Stefan Bürk merged patch set 5 07/19/23, 08:19