Review main Abandoned

79071[WIP][BUGFIX] Only flush specific cache related to SchemaInformation

Stefan Bürk CR 0 V 0 Easy +39 −7 updated 06/01/23, 11:04

Commit message

With #99062 cached schema information has been implemented
to avoid performance issues in usual working places. These
informations needs to be refreshed if changes to the known
database structure are done, for example when executing db
schema updates with the `Database Analazyer` install util.

This introduced reloading `ext_localconf.php` and lead to
registering hooks, if not a imdepotent identifier has been
used. #100840 addressed this and releaxed it by adding a
flag to omit the reloading of `ext_localconf.php` files.

This still leads to flushing all caches, which may lead to
breaking tests in some circumstances because tables of some
database based cache configurations have not been created.

This change now moves the implementation to a new method
in the `ClearCacheService` with the ability to select which
cache(s) should be cleared, fallbacking to clear all caches
if none specified. The old method `clearAll()` dispatches
to the new method `clearCaches()` as this is used for the
`flush cache` feature in the install tool.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 46

  1. Stefan Bürk uploaded patch set 1 05/18/23, 18:56

  2. core-ci voted on patch set 1 V -1 05/18/23, 19:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41914

  3. Stefan Bürk uploaded patch set 2 V -1 05/18/23, 19:12

  4. core-ci voted on patch set 2 V +1 05/18/23, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41915

  5. Helmut Hummel commented on patch set 2 CR -1 05/28/23, 09:53

    My suggestion is to not extend ClearCacheService for another use case, but use the Bootstrap factory for a single cache instead and also introduce a dedicated cache: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79148
  6. Stefan Bürk abandoned the change 06/01/23, 11:04