79093[BUGFIX] Load all backend stylesheets for typo3-backend-icon
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 7
- Build/Sources/TypeScript/backend/element/icon-element.ts1+8 −0
- Build/Sources/TypeScript/backend/icons.ts+1 −1
- Build/Sources/TypeScript/backend/new-content-element-wizard.ts+7 −5
- typo3/sysext/backend/Resources/Public/JavaScript/element/icon-element.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/icons.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/new-content-element-wizard.js+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php1+4 −3
Review log 59
-
Nikita Hovratov uploaded patch set 1 05/19/23, 13:34
-
Nikita Hovratov commented on patch set 1 05/19/23, 13:38
I know this is ugly, but I don't see another solution for now. In the longrun we need to introduce a new API for specific CSS for web components instead / or in parallel to global CSS for the backend. Else, it won't be possible to customize the TYPO3 backend as before, when everything becomes a web component. -
core-ci voted on patch set 1 V -1 05/19/23, 13:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41925
-
Nikita Hovratov uploaded patch set 2
V -105/19/23, 14:10 -
core-ci voted on patch set 2 V -1 05/19/23, 14:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41927
-
core-ci commented on patch set 2 05/19/23, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41927
-
core-ci commented on patch set 2 05/19/23, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41927
-
Oliver Hader commented on patch set 2 07/03/23, 18:04
icon-element.ts:63UnresolvedThis won't work with content-security-policy and `nonce=` values enabled - the nonce is stored in `window.litNonce`. The `lit-helpers.ts` have a function for using inline styles `styleTag`. Besides that (independent of CSP), creating `link` elements in ShadowDOM might lead to problems due to https://developer.mozilla.org/en-US/docs/Web/API/Document/adoptedStyleSheets#sharing_a_stylesheet_with_a_shadow_domPageRenderer.php:2248UnresolvedThis probably should be scoped for `icon-element.ts`, e.g. `iconElementStyles`... -
Nikita Hovratov abandoned the change 07/29/23, 21:13
doesn't work apparently. Help of JS pro needed.