Review main Merged

79133[TASK] Update ckeditor5 to v38.0.1

Andreas Kienast CR +2 V +2 Nightmare +6245 −1653 updated 05/26/23, 05:19

Commit message

Changelog: https://github.com/ckeditor/ckeditor5/blob/v38.0.1/CHANGELOG.md

Executed commands:

    npm i --save \
        @ckeditor/ckeditor5-alignment@^38.0.1 \
        @ckeditor/ckeditor5-autoformat@^38.0.1 \
        @ckeditor/ckeditor5-basic-styles@^38.0.1 \
        @ckeditor/ckeditor5-block-quote@^38.0.1 \
        @ckeditor/ckeditor5-clipboard@^38.0.1 \
        @ckeditor/ckeditor5-code-block@^38.0.1 \
        @ckeditor/ckeditor5-core@^38.0.1 \
        @ckeditor/ckeditor5-dev-utils@^37.0.1 \
        @ckeditor/ckeditor5-editor-classic@^38.0.1 \
        @ckeditor/ckeditor5-engine@^38.0.1 \
        @ckeditor/ckeditor5-essentials@^38.0.1 \
        @ckeditor/ckeditor5-find-and-replace@^38.0.1 \
        @ckeditor/ckeditor5-heading@^38.0.1 \
        @ckeditor/ckeditor5-horizontal-line@^38.0.1 \
        @ckeditor/ckeditor5-html-support@^38.0.1 \
        @ckeditor/ckeditor5-indent@^38.0.1 \
        @ckeditor/ckeditor5-link@^38.0.1 \
        @ckeditor/ckeditor5-list@^38.0.1 \
        @ckeditor/ckeditor5-paragraph@^38.0.1 \
        @ckeditor/ckeditor5-paste-from-office@^38.0.1 \
        @ckeditor/ckeditor5-remove-format@^38.0.1 \
        @ckeditor/ckeditor5-source-editing@^38.0.1 \
        @ckeditor/ckeditor5-special-characters@^38.0.1 \
        @ckeditor/ckeditor5-style@^38.0.1 \
        @ckeditor/ckeditor5-table@^38.0.1 \
        @ckeditor/ckeditor5-theme-lark@^38.0.1 \
        @ckeditor/ckeditor5-ui@^38.0.1 \
        @ckeditor/ckeditor5-undo@^38.0.1 \
        @ckeditor/ckeditor5-utils@^38.0.1 \
        @ckeditor/ckeditor5-word-count@^38.0.1

    npm install --save-dev \
        @rollup/plugin-commonjs

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 56

  1. Andreas Kienast uploaded patch set 1 05/23/23, 08:31

  2. core-ci voted on patch set 1 V +1 05/23/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41969

  3. Benni Mack voted on patch set 1 V +1 CR +1 05/23/23, 09:19

  4. Tymoteusz Motylewski commented on patch set 1 05/23/23, 09:48

    this most probably also fixes https://forge.typo3.org/issues/100348
  5. Georg Ringer voted on patch set 1 V +2 CR +2 05/26/23, 05:19

  6. Georg Ringer merged patch set 2 05/26/23, 05:19