Review main Merged

79147[BUGFIX] Cast IP lock settings to int

Georg Ringer CR +2 V +2 Easy +2 −2 updated 05/31/23, 12:28

Commit message

Avoid exceptions by casting the values to integers.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Thomas Hohn +1
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Jörg Bösche +1
    • Stefan Froemken +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Nikita Hovratov +1
    • Stefan Froemken +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1316

  1. Georg Ringer uploaded patch set 1 05/26/23, 06:24

  2. Georg Ringer commented on patch set 1 05/26/23, 06:24

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 05/26/23, 06:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42040

  4. Benni Mack updated the commit message in patch set 2 V +1 05/26/23, 06:32

  5. Benni Mack updated the commit message in patch set 3 05/26/23, 06:33

  6. Benni Mack voted on patch set 3 V +1 CR +1 05/26/23, 06:33

  7. core-ci voted on patch set 2 V +1 05/26/23, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42041

  8. core-ci voted on patch set 3 V +1 05/26/23, 06:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42042

  9. Nikita Hovratov voted on patch set 3 V +1 CR +1 05/26/23, 07:25

  10. Oliver Klee voted on patch set 3 CR +1 05/26/23, 08:27

  11. Jörg Bösche voted on patch set 3 CR +1 05/26/23, 13:03

  12. Stefan Froemken voted on patch set 3 V +1 CR +1 05/26/23, 14:48

  13. Stefan Froemken commented on patch set 3 05/26/23, 14:50

    IpLocker in TYPO3 11 expects construct parameters as int, too. So, looks good.
  14. Thomas Hohn voted on patch set 3 CR +1 05/31/23, 11:57

  15. Georg Ringer voted on patch set 3 V +2 CR +2 05/31/23, 12:28

  16. Georg Ringer merged patch set 4 05/31/23, 12:28