Review main Merged

79148[TASK] Use dedicated cache for schema information

Helmut Hummel CR +2 V +2 Normal +76 −161 updated 06/10/23, 15:38

Commit message

Using the core cache for schema information comes with
various drawbacks:

1. There is no way to flush single core cache entries,
   thus the complete core cache needs to be flushed when
   changing the database schema.
2. The PHP Frontend provides no benefit, when the to be cached
   information has to be serialized anyway.

Therefore, a new cache is introduced that can be flushed
individually after schema updates.

Flushing the cache is now also moved altogether to SchemaMigrator,
in order to avoid flushing the cache multiple times for multiple
connections. For flushing the individual cache, the internal
Bootstrap::createCache factory is used, which ensures a cache
backend, which is not set to null backend, which happens
with late boot methodology in install tool and replaces the
previously used ClearCacheService, which is only meant to be
used to flush all caches and boots the system for that.

With doing so, the previously introduced argument to not
boot the system can be removed again.

As drive by change the SysLogChannel update is renovated
a bit to not use deprecated Doctrine DBAL API.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 2031

Show 36 earlier messages
  1. Helmut Hummel uploaded patch set 1 05/27/23, 13:33

  2. core-ci voted on patch set 1 V -1 05/27/23, 13:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42058

  3. Helmut Hummel uploaded patch set 2 V -1 05/27/23, 14:00

  4. core-ci voted on patch set 2 V -1 05/27/23, 14:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42059

  5. Helmut Hummel uploaded patch set 3 V -1 05/27/23, 14:12

  6. core-ci voted on patch set 3 V -1 05/27/23, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42060

  1. Helmut Hummel uploaded patch set 4 V -1 05/28/23, 08:33

  2. core-ci voted on patch set 4 V +1 05/28/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42067

  3. Helmut Hummel uploaded patch set 5 V +1 05/28/23, 09:07

  4. Helmut Hummel updated the commit message in patch set 6 05/28/23, 09:12

  5. core-ci voted on patch set 5 V +1 05/28/23, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42068

  6. core-ci voted on patch set 6 V +1 05/28/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42069

  7. Helmut Hummel uploaded patch set 7 V +1 05/28/23, 10:35

  8. Helmut Hummel uploaded patch set 8 05/28/23, 10:40

  9. core-ci voted on patch set 8 V +1 05/28/23, 10:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42074

  10. core-ci voted on patch set 7 V -1 05/28/23, 10:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42073

  11. Stefan Bürk commented on patch set 8 V +1 CR +1 05/28/23, 12:15

    Thanks Helmut. Didn't found the Bootstrap::createCache() when originally adding the cache clear to to migrator to get the databaseschema cleaned. The move into a dedicated cache makes much more sense now, specially taking deployment strategies into account (Thanks for the explanation in slack for this). Reverting the hack to avoid registering hooks twice(multiple times) makes sense thou as it have only been needed because of my connecting to it.
  12. Stefan Bürk commented on patch set 8 05/28/23, 12:17

    I want Benni to have a look on this.
  13. Stefan Bürk commented on patch set 8 V 0 CR 0 06/01/23, 11:02

    Talked with benni. We will handle this as task and add a important rest file to it. Will take care of it when I find some time.
  14. Stefan Bürk uploaded patch set 9 V +1 06/08/23, 15:34

  15. core-ci voted on patch set 9 V +1 06/08/23, 15:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42318

  16. Stefan Bürk voted on patch set 9 V +1 CR +1 06/08/23, 15:46

  17. Stefan Bürk updated the commit message in patch set 10 CR +1 V +1 06/08/23, 15:46

  18. Stefan Bürk voted on patch set 10 V +1 CR +1 06/08/23, 15:46

  19. Stefan Bürk updated the commit message in patch set 11 CR +1 V +1 06/08/23, 15:46

  20. Stefan Bürk voted on patch set 11 V +1 CR +1 06/08/23, 15:47

  21. core-ci voted on patch set 10 V +1 06/08/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42320

  22. core-ci voted on patch set 11 V +1 06/08/23, 15:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42321

  23. Benni Mack voted on patch set 11 V +1 CR +1 06/10/23, 07:36

  24. Stefan Bürk voted on patch set 11 V +2 CR +2 06/10/23, 15:38

  25. Stefan Bürk merged patch set 12 06/10/23, 15:38