Review main Abandoned

79150[BUGFIX] Fix symfony/property-info to max version 6.2.10

Anja Leichsenring CR 0 V 0 Easy +9 −9 updated 05/28/23, 12:37

Commit message

Handling of properties without types has changed in version 6.2.11,
leading to changed behavior as displayed by the failing test.
In order to maintain stable functionality for TYPO3 core, the
last unchanged version is fixed for now as the maximum version.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Anja Leichsenring uploaded patch set 1 05/28/23, 09:48

  2. core-ci voted on patch set 1 V -1 05/28/23, 09:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42070

  3. Oliver Klee commented on patch set 1 05/28/23, 10:02

    Is this a bug in symfony/property-info? If so, is there already a bug report or PR for it?
  4. Anja Leichsenring uploaded patch set 2 V -1 05/28/23, 10:21

  5. Anja Leichsenring commented on patch set 2 05/28/23, 10:23

    Reply

    I am not sure it is a bug, can very well be intended. I will get in contact with Alex Schnitzler for a more sophisticated solution than just preventing install, but for now it brings our nightlies back to green.
  6. core-ci voted on patch set 2 V +1 05/28/23, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42072

  7. Stefan Bürk commented on patch set 2 CR -1 05/28/23, 10:33

    We should not pin it if we are not sure if it is a bug on our side or on symfony. at least we should report it at symfony and link the the issue with this change. Therefore the temp -1. Will have a look into that topic soonish.
  8. Stefan Bürk abandoned the change 05/28/23, 12:37

    Abandong in favour of https://review.typo3.org/c/Packages/TYPO3.CMS/+/79151. However, thanks Anja for the kickstart.