Review main Merged

79151[BUGFIX] Update `symfony/property-info` to v6.2.11

Andreas Kienast CR +2 V +2 Easy +18 −13 updated 05/28/23, 14:14

Commit message

Handling of collections without a dedicated type has changed in
`symfony/property-info` with v6.2.11, [1] seems to be the offensive
commit.

This should be backward compatible, as only string|int make
sense for array keys and therefore is the same for array-like
object annotation syntax.

We raise the version constraint for `symfony/property-info`
package to a slightly higher patchlevel version to ensure
consistent behaviour. This is done for shipped version and
the core development, therefore the raises are also added
to the corresponding extension composer.json files.

Used command(s):

> composer require --no-update \
    -d typo3/sysext/extbase \
    "symfony/property-info":"^6.2.11"

> composer require \
    "symfony/property-info":"^6.2.11"

[1] https://github.com/symfony/symfony/pull/49557

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 1016

  1. Andreas Kienast uploaded patch set 1 05/28/23, 11:12

  2. Andreas Kienast commented on patch set 1 05/28/23, 11:13

    Please note this patch may not be the holy grail as this _could_ have other regressions.
  3. Andreas Kienast uploaded patch set 2 05/28/23, 11:14

  4. core-ci voted on patch set 2 V +1 05/28/23, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42077

  5. core-ci voted on patch set 1 V +1 05/28/23, 11:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42076

  6. Oliver Klee voted on patch set 2 V +1 CR +1 05/28/23, 12:19

  7. Stefan Bürk voted on patch set 2 CR -1 05/28/23, 12:20

  8. core-ci voted on patch set 2 V -1 05/28/23, 12:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42078

  9. Stefan Bürk uploaded patch set 3 CR +1 V +1 05/28/23, 12:49

  10. core-ci voted on patch set 3 V +1 05/28/23, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42079

  11. Stefan Bürk commented on patch set 3 05/28/23, 12:57

  12. Oliver Klee voted on patch set 3 V +1 CR +1 05/28/23, 13:04

  13. core-ci voted on patch set 3 V -1 05/28/23, 13:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42080

  14. core-ci voted on patch set 3 V +1 05/28/23, 13:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42080

  15. Stefan Bürk voted on patch set 3 V +2 CR +2 05/28/23, 14:14

  16. Stefan Bürk merged patch set 4 05/28/23, 14:14