79159[TASK] Use local variable in `CleanUpLocalProcessedFilesCommand`
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Hader +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Andreas Kienast +1
Issues 1
Files 1
Review log 1520
-
Stefan Bürk uploaded patch set 1 06/01/23, 10:26
-
core-ci voted on patch set 1 V +1 06/01/23, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42145
-
Stefan Bürk commented on patch set 1 06/01/23, 10:34
Running nightly on it: https://git.typo3.org/typo3/CI/cms/-/pipelines/42146 -
core-ci commented on patch set 1 06/01/23, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42146
-
Andreas Kienast commented on patch set 1 06/01/23, 11:06
I think that phpstan has an issue with the code because `isVerbose()` _could_ suddenly return a different value which would indeed lead to "Variable $progressBar might not be defined" -
Stefan Bürk commented on patch set 1 06/01/23, 11:11
Reply
Ack. Anyway, the change should avoid that in static code anaylzes and processing. A suggestion how to change the commit message ? -
Andreas Kienast voted on patch set 1 CR +1 06/01/23, 11:13
-
Andreas Kienast updated the commit message in patch set 2
CR +1V +106/01/23, 11:15 -
Anja Leichsenring updated the commit message in patch set 3 06/01/23, 11:15
-
Anja Leichsenring voted on patch set 3 V +1 CR +1 06/01/23, 11:15
-
Andreas Kienast updated the commit message in patch set 4
CR +1V +106/01/23, 11:18 -
Andreas Kienast voted on patch set 4 V +1 CR +1 06/01/23, 11:19
-
Stefan Bürk commented on patch set 4 06/01/23, 11:20
Reply
Done -
Oliver Klee voted on patch set 4 V +1 CR +1 06/01/23, 11:27
-
core-ci voted on patch set 2 V +1 06/01/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42149
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 06/01/23, 11:28
-
Anja Leichsenring merged patch set 5 06/01/23, 11:28
-
core-ci voted on patch set 3 V +1 06/01/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42150
-
core-ci voted on patch set 4 V +1 06/01/23, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42151
-
Oliver Hader commented on patch set 5 CR +2 06/01/23, 12:16
Actually the behavior of PhpStan is correct (better) here. There is no guarantee, that consecutive function calls return the same value...