Review main Merged

79162[TASK] Allow f:asset.css and f:asset.script to use CSP nonce

Kevin Appelt CR +2 V +2 Easy +8 −8 updated 06/03/23, 08:17

Commit message

Adds new boolean `useNonce` attribute to asset view helpers, e.g.
`<f:asset.css useNonce="1">` or `<f:asset.script useNonce="1">`.
This way the `AssetRenderer` is instructed to apply the global
dynamic nonce value.

The previous change for issue #100732 did only consider inline
scripts and stylesheets.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 913

  1. Kevin Appelt uploaded patch set 1 06/02/23, 16:39

  2. core-ci voted on patch set 1 V +1 06/02/23, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42165

  3. Stefan Bürk updated the commit message in patch set 2 V +1 06/02/23, 16:50

  4. core-ci voted on patch set 2 V +1 06/02/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42166

  5. Oliver Hader updated the commit message in patch set 3 V +1 06/02/23, 18:07

  6. Oliver Hader updated the commit message in patch set 4 06/02/23, 18:07

  7. Oliver Hader voted on patch set 4 V +1 CR +1 06/02/23, 18:09

  8. core-ci voted on patch set 3 V +1 06/02/23, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42167

  9. core-ci voted on patch set 4 V +1 06/02/23, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42168

  10. Benni Mack voted on patch set 4 V +1 CR +1 06/02/23, 21:46

  11. Stefan Bürk voted on patch set 4 V +1 CR +1 06/03/23, 07:40

  12. Oliver Hader voted on patch set 4 V +2 CR +2 06/03/23, 08:17

  13. Oliver Hader merged patch set 5 06/03/23, 08:17