79163[TASK] Add comments for methods in ModifyVersionDifferencesEvent
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Sybille Peters +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Sybille Peters +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1519
-
Chris Müller uploaded patch set 1 06/02/23, 18:26
-
core-ci voted on patch set 1 V +1 06/02/23, 18:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42169
-
Oliver Klee commented on patch set 1 06/02/23, 18:37
-
Chris Müller commented on patch set 1 06/02/23, 18:51
ModifyVersionDifferencesEvent.php:43ReplyThought also about it. But: The list of fields is necessary anyway to describe the purpose of the keys. And the according class properties (which are returned by the methods) are already described by array shapes. -
Oliver Klee commented on patch set 1 06/02/23, 20:09
ModifyVersionDifferencesEvent.php:43ReplyThe I propose we still add an `@return` annotation with the array shapes. This will allow PHPStan to help devs who write code that calls this method. -
Chris Müller uploaded patch set 2
V +106/03/23, 05:28 -
Chris Müller commented on patch set 2 06/03/23, 05:29
ModifyVersionDifferencesEvent.php:43ReplyAck -
core-ci voted on patch set 2 V -1 06/03/23, 05:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42177
-
Sybille Peters commented on patch set 2 06/03/23, 05:50
ModifyVersionDifferencesEvent.php:65should be @return, I guess. -
Chris Müller uploaded patch set 3
V -106/03/23, 06:06 -
Chris Müller uploaded patch set 4 06/03/23, 06:07
-
Chris Müller commented on patch set 4 06/03/23, 06:07
ModifyVersionDifferencesEvent.php:65ReplyDone -
core-ci voted on patch set 4 V +1 06/03/23, 06:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42179
-
core-ci voted on patch set 3 V +1 06/03/23, 06:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42178
-
Oliver Klee voted on patch set 4 V +1 CR +1 06/03/23, 07:24
-
Sybille Peters voted on patch set 4 CR +1 06/03/23, 08:20
-
Sybille Peters voted on patch set 4 V +1 06/04/23, 07:38
-
Benni Mack voted on patch set 4 V +2 CR +2 06/05/23, 06:20
-
Benni Mack merged patch set 5 06/05/23, 06:20
ModifyVersionDifferencesEvent.php:43