Review main Merged

79165[TASK] Make TSconfig list case-insensitive

Sybille Peters CR +2 V +2 Easy +1 −1 updated 06/07/23, 10:51

Commit message

The "Page TSconfig" module in the Backend lists the TSconfig
configuration. The view "Active page TSconfig" used to list
the items case-sensitively (if "Sort keys alphabetically" is
enabled). Since some of the top-level keys are all lowercase
and some are all uppercase, it is better to use a case-insensitive
ordering.

Review

  • Code review CR +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Jasmina Ließmann +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Sybille Peters uploaded patch set 1 06/03/23, 05:18

  2. core-ci voted on patch set 1 V +1 06/03/23, 05:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42176

  3. Christian Kuhn commented on patch set 1 CR -1 06/06/23, 13:50

    why not hard code those flags? this would avoid the constructor arguments.
  4. Sybille Peters uploaded patch set 2 CR -1 V +1 06/06/23, 14:04

  5. Sybille Peters commented on patch set 2 06/06/23, 14:05

    Reply

    ok
  6. core-ci voted on patch set 2 V +1 06/06/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42233

  7. Jasmina Ließmann voted on patch set 2 V +1 CR +1 06/07/23, 10:49

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 06/07/23, 10:49

  9. Jasmina Ließmann voted on patch set 2 V +2 CR +2 06/07/23, 10:51

  10. Jasmina Ließmann merged patch set 3 06/07/23, 10:51