Review 12.4 Merged

79166[TASK] Allow f:asset.css and f:asset.script to use CSP nonce

Oliver Hader CR +2 V +2 Easy +8 −8 updated 06/03/23, 08:18

Commit message

Adds new boolean `useNonce` attribute to asset view helpers, e.g.
`<f:asset.css useNonce="1">` or `<f:asset.script useNonce="1">`.
This way the `AssetRenderer` is instructed to apply the global
dynamic nonce value.

The previous change for issue #100732 did only consider inline
scripts and stylesheets.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oliver Hader uploaded patch set 1 06/03/23, 08:00

  2. core-ci voted on patch set 1 V +1 06/03/23, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42180

  3. Oliver Hader voted on patch set 1 V +2 CR +2 06/03/23, 08:17

  4. Oliver Hader merged patch set 2 06/03/23, 08:18