Review 12.4 Merged

79167[TASK] Allow nonce values explicitly in PageRenderer inline methods

Oliver Hader CR +2 V +2 Normal +96 −51 updated 06/03/23, 08:25

Commit message

Allow to use nonce explicitly for `PageRenderer` methods
`addJsInlineCode()`, `addJsFooterInlineCode()` and
`addCssInlineBlock()`.

The backend login styles are already using those nonce values.
As a consequence, the variable values `loginBackgroundImage`
and `loginHighlightColor` have to be sanitized by the new
`GeneralUtility::sanitizeCssVariableValue()` function.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Oliver Hader uploaded patch set 1 06/03/23, 08:03

  2. core-ci voted on patch set 1 V +1 06/03/23, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42181

  3. Oliver Hader voted on patch set 1 V +2 CR +2 06/03/23, 08:24

  4. Oliver Hader merged patch set 2 06/03/23, 08:25