79197[BUGFIX] Make Extbase ObjectConverter consider XCLASSed objects
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1521
-
Torben Hansen uploaded patch set 1 06/06/23, 17:22
-
core-ci voted on patch set 1 V +1 06/06/23, 17:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42242
-
Oliver Klee commented on patch set 1 06/06/23, 19:49
-
Torben Hansen commented on patch set 1 06/07/23, 05:44
ObjectConverter.php:221ReplyNo, since line 212 only applies to the `__type` scenario. I will update the patch, so `GeneralUtility::getClassName()` is used as Alex Schnitzler suggested. -
Torben Hansen uploaded patch set 2
V +106/07/23, 06:02 -
core-ci voted on patch set 2 V +1 06/07/23, 06:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42250
-
Oliver Klee commented on patch set 2 06/07/23, 07:48
Please let's cover this with tests. -
Torben Hansen uploaded patch set 3
V +106/08/23, 05:52 -
Torben Hansen commented on patch set 2 06/08/23, 05:52
Reply
Done -
core-ci voted on patch set 3 V -1 06/08/23, 06:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42283
-
Torben Hansen uploaded patch set 4
V -106/08/23, 06:25 -
core-ci voted on patch set 4 V -1 06/08/23, 06:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42284
-
Torben Hansen uploaded patch set 5
V -106/08/23, 06:35 -
core-ci voted on patch set 5 V +1 06/08/23, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42285
-
Oliver Klee commented on patch set 5 06/08/23, 07:11
ObjectConverterTest.php:461I'd like to propose this name: `convertWithRegisteredSubclassReturnsInstanceOfRegisteredSubclass`ObjectConverterTest.php:473We don't need this annotation as we're going to check this with the `assertInstanceOf` call a few lines further below anyway.ObjectConverterTest.php:481This assertion is not part of what the test is about (that it's an instance of the registered subclass). We probably should either remove it (that's what I would recommend), or (if it's important) move it to a separate test name `convertWithRegisteredSubclassSetsProperties` -
Torben Hansen uploaded patch set 6
V +106/08/23, 07:59 -
Torben Hansen commented on patch set 5 06/08/23, 07:59
ObjectConverterTest.php:461ReplyDoneObjectConverterTest.php:473ReplyDoneObjectConverterTest.php:481ReplyDone -
Oliver Klee voted on patch set 6 V +1 CR +1 06/08/23, 08:06
-
core-ci voted on patch set 6 V +1 06/08/23, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42287
-
Christian Kuhn voted on patch set 6 V +2 CR +2 06/08/23, 12:03
-
Christian Kuhn merged patch set 7 06/08/23, 12:03
ObjectConverter.php:221