Review main Merged

79200[BUGFIX] SaveToDatabaseFinisher uses parseOption to evaluate mode

Markus Klein CR +2 V +2 Easy +8 −8 updated 06/08/23, 12:58

Commit message

If the mode is not specified in the configuration,
the default must be used.
The defaultOption can only be retrieved
if the `parseOption` method is used.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Johannes Kasberger +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Johannes Kasberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1420

  1. Markus Klein uploaded patch set 1 06/07/23, 08:15

  2. Thomas Hohn voted on patch set 1 CR +1 06/07/23, 08:19

  3. Benni Mack voted on patch set 1 CR +1 06/07/23, 08:21

  4. Johannes Kasberger voted on patch set 1 V +1 CR +1 06/07/23, 08:22

  5. core-ci voted on patch set 1 V -1 06/07/23, 08:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42253

  6. Mathias Brodala updated the commit message in patch set 2 CR +1 V +1 06/07/23, 08:27

  7. core-ci voted on patch set 2 V -1 06/07/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42254

  8. Oliver Hader voted on patch set 2 CR +1 06/07/23, 08:38

  9. Markus Klein uploaded patch set 3 CR +1 V -1 06/07/23, 08:56

  10. core-ci voted on patch set 3 V -1 06/07/23, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42257

  11. Markus Klein uploaded patch set 4 V -1 06/07/23, 09:05

  12. core-ci voted on patch set 4 V -1 06/07/23, 09:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42258

  13. Markus Klein uploaded patch set 5 V -1 06/07/23, 09:36

  14. core-ci voted on patch set 5 V -1 06/07/23, 09:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42261

  15. Markus Klein uploaded patch set 6 V -1 06/07/23, 14:23

  16. core-ci voted on patch set 6 V +1 06/07/23, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42274

  17. Thomas Hohn voted on patch set 6 CR +1 06/07/23, 19:06

  18. Johannes Kasberger voted on patch set 6 V +1 CR +1 06/07/23, 19:08

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 06/08/23, 12:58

  20. Christian Kuhn merged patch set 7 06/08/23, 12:58