Review 12.4 Merged

79204[BUGFIX] Grant inline scripts & styles via CSP in admin panel output

Oliver Hader CR +2 V +2 Normal +126 −16 updated 06/26/23, 11:53

Commit message

The admin panel uses Symfony's `HtmlDumper` to output data - which is
adding inline JavaScript and StyleSheet elements. To be compatible with
CSP those elements need to be allowed with a nonce attribute.

This change relies on a merged pull request for Symfony v6.3:
https://github.com/symfony/symfony/pull/49977

Executed commands:
composer req symfony/var-dumper:^6.3
composer req symfony/var-dumper:^6.3 \
  -d typo3/sysext/adminpanel --no-update

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 46

  1. Oliver Hader uploaded patch set 1 06/07/23, 10:30

  2. core-ci voted on patch set 1 V +1 06/07/23, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42268

  3. Oliver Hader uploaded patch set 2 V +1 06/26/23, 08:47

  4. core-ci voted on patch set 2 V +1 06/26/23, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42981

  5. Oliver Hader voted on patch set 2 V +2 CR +2 06/26/23, 11:53

  6. Oliver Hader merged patch set 3 06/26/23, 11:53