Review main Merged

79206[BUGFIX] Handle CSP nonce values having uncached items

Oliver Hader CR +2 V +2 Easy +13 −3 updated 06/14/23, 12:21

Commit message

When having uncached items (COA_INT, USER_INT) during the
frontend rendering process, the PageRenderer state will be
serialized and preserved for later usage. As a result, none
of the nonce values is actually consumed at that point.

This change triggers the nonce handling in case uncached
items exist. Besides that, the state of the nonce value is
considered during the serialization process.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 911

  1. Oliver Hader uploaded patch set 1 06/07/23, 12:58

  2. core-ci voted on patch set 1 V +1 06/07/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42273

  3. Andreas Kienast commented on patch set 1 06/13/23, 06:08

    PageRenderer.php:373

    This is now done for all cases (including `nonce`) up to this point. Is this intended?
  4. Oliver Hader commented on patch set 1 06/13/23, 21:17

    PageRenderer.php:373 Reply

    Good catch. All other previous cases still should terminate...
  5. Oliver Hader commented on patch set 2 V +1 06/13/23, 21:18

    Published edit on patch set 1.
  6. Oliver Hader commented on patch set 2 06/13/23, 21:19

    PageRenderer.php:373 Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/13/23, 21:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42496

  8. Benni Mack voted on patch set 2 V +1 CR +1 06/13/23, 21:40

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 06/14/23, 11:59

  10. Benni Mack voted on patch set 2 V +2 CR +2 06/14/23, 12:21

  11. Benni Mack merged patch set 3 06/14/23, 12:21