Review main Merged

79235[BUGFIX] Full page in ConditionMatcher from PageTsConfigFactory

Nikita Hovratov CR +2 V +2 Easy +7 −2 updated 06/08/23, 13:08

Commit message

In order for PageTSConfig conditions to work properly on all
fields of the page, the full page record needs to be handed
over to the ConditionMatcher.

A similar bugfix was already done in #100764, but it only
included the Frontend context.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Elias Häußler +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Elias Häußler +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 68

  1. Nikita Hovratov uploaded patch set 1 06/08/23, 11:24

  2. core-ci voted on patch set 1 V +1 06/08/23, 11:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42298

  3. Christian Kuhn uploaded patch set 2 V +1 06/08/23, 12:11

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 06/08/23, 12:11

  5. core-ci voted on patch set 2 V +1 06/08/23, 12:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42302

  6. Elias Häußler voted on patch set 2 V +1 CR +1 06/08/23, 13:06

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/08/23, 13:07

  8. Christian Kuhn merged patch set 3 06/08/23, 13:08