Review main Merged

79239[TASK] Streamline indentation of arrays and comments

Simon Gilli CR +2 V +2 Nightmare +2434 −2433 updated 01/04/24, 19:11

Commit message

PHP-CS-Fixer rule `array_indentation` is activated to have
consistent indentation of arrays.

In addition, a full run of php-cs-fixer without
caches shows also affected areas where comments
did not apply properly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 97

Show 77 more files

Review log 1214

  1. Simon Gilli uploaded patch set 1 06/08/23, 12:39

  2. Benni Mack uploaded patch set 2 01/04/24, 14:46

  3. Benni Mack marked it ready for review 01/04/24, 14:46

  4. Benni Mack wrote 01/04/24, 14:47

    Unset private
  5. core-ci voted on patch set 2 V +1 01/04/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51107

  6. Oliver Klee voted on patch set 2 CR +1 V +1 01/04/24, 14:57

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/04/24, 15:10

  8. Simon Schaufelberger uploaded patch set 3 CR +1 V +1 01/04/24, 17:20

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/04/24, 17:20

  10. Oliver Klee voted on patch set 3 CR +1 V +1 01/04/24, 17:23

  11. core-ci voted on patch set 3 V +1 01/04/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51113

  12. Oli Bartsch voted on patch set 3 CR +1 V +1 01/04/24, 18:35

  13. Benni Mack voted on patch set 3 CR +2 V +2 01/04/24, 19:11

  14. Benni Mack merged patch set 4 01/04/24, 19:11