79239[TASK] Streamline indentation of arrays and comments
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Oliver Klee +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 97
- Build/php-cs-fixer/config.php+1 −0
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ColumnSelectorController.php+1 −1
- typo3/sysext/backend/Classes/Controller/LoginController.php+1 −1
- typo3/sysext/backend/Classes/Controller/ResetPasswordController.php+3 −3
- typo3/sysext/backend/Classes/Form/Element/SelectSingleBoxElement.php+1 −1
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php+5 −5
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+1 −1
- typo3/sysext/backend/Classes/RecordList/DatabaseRecordList.php+13 −13
- typo3/sysext/backend/Classes/Tree/FileStorageTreeProvider.php+2 −2
- typo3/sysext/backend/Tests/Functional/Controller/Page/TreeControllerTest.php+10 −10
- typo3/sysext/backend/Tests/Functional/Controller/EditDocumentControllerTest.php+7 −7
- typo3/sysext/backend/Tests/Functional/Controller/ResetPasswordControllerTest.php+6 −6
- typo3/sysext/backend/Tests/Functional/RecordList/DownloadRecordListTest.php+25 −25
- typo3/sysext/backend/Tests/Functional/Template/Components/Buttons/Action/ShortcutButtonTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Controller/Wizard/SuggestWizardControllerTest.php+5 −5
- typo3/sysext/backend/Tests/Unit/Form/Element/InputHiddenElementTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Element/JsonElementTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowInitializeNewTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaLanguageTest.php+33 −33
Show 77 more files
- typo3/sysext/backend/Tests/Unit/Module/ModuleFactoryTest.php+1 −1
- typo3/sysext/backend/Tests/Unit/Utility/BackendUtilityTest.php+2 −2
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+3 −3
- typo3/sysext/core/Classes/Database/Schema/DefaultTcaSchema.php+4 −4
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+1 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+6 −6
- typo3/sysext/core/Classes/Html/SimpleParser.php+8 −8
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −1
- typo3/sysext/core/Classes/Resource/MimeTypeCollection.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+1 −1
- typo3/sysext/core/Classes/Security/ContentSecurityPolicy/PolicyProvider.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+4 −4
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/HookTest.php+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/Slug/SlugHelperTest.php+7 −7
- typo3/sysext/core/Tests/Functional/RegistryTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+7 −7
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+3 −3
- typo3/sysext/core/Tests/Unit/Http/ServerRequestFactoryTest.php+25 −25
- typo3/sysext/core/Tests/Unit/Mail/MailMessageTest.php+5 −5
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+3 −3
- typo3/sysext/core/Tests/Unit/TypoScript/AST/AstBuilderInterfaceTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+1 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+1 −1
- typo3/sysext/extbase/Classes/Routing/ExtbasePluginEnhancer.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php+40 −40
- typo3/sysext/extbase/Tests/Functional/Utility/LocalizationUtilityTest.php+11 −11
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+6 −6
- typo3/sysext/fluid/Classes/ViewHelpers/FormViewHelper.php+1 −1
- typo3/sysext/fluid/Tests/Functional/ViewHelpers/FormViewHelperTest.php+1 −1
- typo3/sysext/form/Classes/EventListener/DataStructureIdentifierListener.php+9 −9
- typo3/sysext/form/Tests/Functional/RequestHandling/RequestHandlingTest.php+5 −5
- typo3/sysext/form/Tests/Functional/Service/TranslationServiceTest.php+5 −5
- typo3/sysext/form/Tests/Unit/Domain/Configuration/FormDefinitionConversionServiceTest.php+44 −44
- typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+28 −28
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+1 −1
- typo3/sysext/frontend/Classes/DataProcessing/GalleryProcessor.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/PageArgumentValidator.php+1 −1
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequest/PersistedAliasMapperTest.php+7 −7
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/DataProcessing/FlexFormProcessorTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Export/PagesAndTtContentTest.php+2 −2
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecords.php+284 −284
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportPageAndRecordsWithSoftRefs.php+188 −188
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportRecords.php+81 −81
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewExportTable.php+124 −124
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecords.php+154 −154
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdate.php+122 −122
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsByUpdateWithDiff.php+493 −493
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithDiff.php+308 −308
- typo3/sysext/impexp/Tests/Functional/Fixtures/ArrayAssertions/RenderPreviewImportPageAndRecordsWithSoftRefs.php+106 −106
- typo3/sysext/impexp/Tests/Functional/Import/PagesAndTtContentWithImagesInEmptyDatabaseTest.php+1 −1
- typo3/sysext/impexp/Tests/Functional/ImportTest.php+9 −9
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+3 −3
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+8 −8
- typo3/sysext/install/Classes/Configuration/Mail/SendmailPreset.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyProtectedMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyPublicMatcherTest.php+1 −1
- typo3/sysext/linkvalidator/Classes/Controller/LinkValidatorController.php+5 −5
- typo3/sysext/linkvalidator/Tests/Functional/Repository/BrokenLinkRepositoryTest.php+11 −11
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+11 −11
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+7 −7
- typo3/sysext/redirects/Classes/Controller/ManagementController.php+3 −3
- typo3/sysext/reports/Classes/Report/Status/ImageProcessingStatus.php+1 −1
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php+3 −3
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_ctrl_common.php+86 −86
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_ctrl_minimal.php+21 −21
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_valuesdefault.php+1 −1
- typo3/sysext/styleguide/ext_tables.php+7 −7
Review log 1214
-
Simon Gilli uploaded patch set 1 06/08/23, 12:39
-
Benni Mack uploaded patch set 2 01/04/24, 14:46
-
Benni Mack marked it ready for review 01/04/24, 14:46
-
Benni Mack wrote 01/04/24, 14:47
Unset private -
core-ci voted on patch set 2 V +1 01/04/24, 14:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51107
-
Oliver Klee voted on patch set 2 CR +1 V +1 01/04/24, 14:57
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 01/04/24, 15:10
-
Simon Schaufelberger uploaded patch set 3
CR +1V +101/04/24, 17:20 -
Simon Schaufelberger voted on patch set 3 CR +1 V +1 01/04/24, 17:20
-
Oliver Klee voted on patch set 3 CR +1 V +1 01/04/24, 17:23
-
core-ci voted on patch set 3 V +1 01/04/24, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51113
-
Oli Bartsch voted on patch set 3 CR +1 V +1 01/04/24, 18:35
-
Benni Mack voted on patch set 3 CR +2 V +2 01/04/24, 19:11
-
Benni Mack merged patch set 4 01/04/24, 19:11