79243[BUGFIX] Use correct type in DB query
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 67
-
Sybille Peters uploaded patch set 1 06/08/23, 15:43
-
core-ci voted on patch set 1 V +1 06/08/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42319
-
Oliver Klee voted on patch set 1 CR +1 06/08/23, 15:54
-
Stefan Bürk commented on patch set 1 V +1 CR +1 06/11/23, 02:28
Due to this is a bugfix to be backported, the used type is okay. We will change this for main anyway along when we work towards doctrine/dbal 4.x. Thanks for providing the patch. -
Sybille Peters commented on patch set 1 06/11/23, 04:47
Reply
Do you mean changing from PARAM_STR_ARRAY to ArrayParameterType::STRING as it is deprecated in doctrine/dbal? I saw that but used PARAM_STR_ARRAY. Actually in the main branch, both are used. Thanks. -
Christian Kuhn voted on patch set 1 V +2 CR +2 06/11/23, 21:42
-
Christian Kuhn merged patch set 2 06/11/23, 21:42