Review main Merged

79243[BUGFIX] Use correct type in DB query

Sybille Peters CR +2 V +2 Easy +1 −1 updated 06/11/23, 21:42

Commit message

A database query was executed when creating a scheduler
task which fetched all optimizable tables.

This was executed with the wrong type in createNamedParameter
(string instead of string array) and resulted in exception in
some scenarios (with MySQL, with additional table mappings).

The problem is now fixed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Sybille Peters uploaded patch set 1 06/08/23, 15:43

  2. core-ci voted on patch set 1 V +1 06/08/23, 15:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42319

  3. Oliver Klee voted on patch set 1 CR +1 06/08/23, 15:54

  4. Stefan Bürk commented on patch set 1 V +1 CR +1 06/11/23, 02:28

    Due to this is a bugfix to be backported, the used type is okay. We will change this for main anyway along when we work towards doctrine/dbal 4.x. Thanks for providing the patch.
  5. Sybille Peters commented on patch set 1 06/11/23, 04:47

    Reply

    Do you mean changing from PARAM_STR_ARRAY to ArrayParameterType::STRING as it is deprecated in doctrine/dbal? I saw that but used PARAM_STR_ARRAY. Actually in the main branch, both are used. Thanks.
  6. Christian Kuhn voted on patch set 1 V +2 CR +2 06/11/23, 21:42

  7. Christian Kuhn merged patch set 2 06/11/23, 21:42