Review main Merged

79245[TASK] Speed up SysLogSerializationUpdate

Thomas Hohn CR +2 V +2 Easy +16 −0 updated 06/11/23, 21:57

Commit message

Speed up the SysLogSerializationUpdate migration wizard
for trivial cases like a:0:{} and a:1:{i:0;s:0:"";}.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Thomas Hohn uploaded patch set 1 06/09/23, 08:38

  2. core-ci voted on patch set 1 V +1 06/09/23, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42330

  3. Markus Klein commented on patch set 1 06/09/23, 11:28

    SysLogSerializationUpdate.php:68

    I don't understand this case. json_encode(unserialize('a:1:{i:0;s:0:"";}')); Is `[""]` and not `[]` What am I missing?
  4. Thomas Hohn commented on patch set 1 06/09/23, 11:32

    SysLogSerializationUpdate.php:68 Reply

    I was assuming that the log-entry [] and [""] would "mean" the same when showing the data in the backend - but I might be wrong and in that case I should be [""] in this case.
  5. Thomas Hohn uploaded patch set 2 V +1 06/09/23, 12:31

  6. Thomas Hohn commented on patch set 2 06/09/23, 12:32

    SysLogSerializationUpdate.php:68 Reply

    Done
  7. core-ci voted on patch set 2 V +1 06/09/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42332

  8. Markus Klein voted on patch set 2 V +1 CR +1 06/10/23, 19:47

  9. Nikita Hovratov voted on patch set 2 V +1 CR +1 06/10/23, 21:11

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 06/11/23, 21:57

  11. Christian Kuhn merged patch set 3 06/11/23, 21:57