Review main Merged

79247[BUGFIX] Use correct `typo3/cms-styleguide` for main

Nikita Hovratov CR +2 V +2 Easy +12 −12 updated 06/09/23, 16:02

Commit message

Branching in `typo3/cms-styleguide` have been done
some time after the core branched versions. That
led to an invalid state in composer.json/lock and
further issues, for example when using the composer
lock file update command: `composer update --lock`

This now leads to weird constellations. Therefore,
we now require the correct version of styleguide
to break that invalid cycle and have correct version
in the `composer.json` and `composer.lock` files.

Used command(s):

> composer require --dev "typo3/cms-styleguide":"~13.0@dev"

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 913

  1. Nikita Hovratov uploaded patch set 1 06/09/23, 15:29

  2. Nikita Hovratov updated the commit message in patch set 2 06/09/23, 15:31

  3. core-ci voted on patch set 1 V +1 06/09/23, 15:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42333

  4. core-ci voted on patch set 2 V +1 06/09/23, 15:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42334

  5. Stefan Bürk uploaded patch set 3 V +1 06/09/23, 15:51

  6. Nikita Hovratov updated the commit message in patch set 4 06/09/23, 15:54

  7. Stefan Bürk voted on patch set 4 V +1 CR +1 06/09/23, 15:56

  8. core-ci voted on patch set 3 V +1 06/09/23, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42335

  9. Nikita Hovratov voted on patch set 4 V +1 CR +1 06/09/23, 15:59

  10. Anja Leichsenring voted on patch set 4 V +1 CR +1 06/09/23, 16:01

  11. core-ci voted on patch set 4 V +1 06/09/23, 16:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42336

  12. Anja Leichsenring voted on patch set 4 V +2 CR +2 06/09/23, 16:02

  13. Anja Leichsenring merged patch set 5 06/09/23, 16:02