79249[BUGFIX] Resolve page with trailing slash requested without one
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Nikita Hovratov +1
- Benni Mack +1
- core-ci +1 CI
Issues 5
- Bug #100990Pages with trailing slash in slug are not resolved if requested uri does not contain a trailing slash
- Bug #96010Translated pages can be loaded with slug of default language
- Bug #88715Wrong routes for default url slugs on translated base path pages
- Bug #89091Page with a slug with trailing slash results in 404
- Bug #86055pages.slug always removes the trailing slash
Files 3
Review log 1521
-
Stefan Bürk uploaded patch set 1 06/10/23, 15:26
-
Stefan Bürk updated the commit message in patch set 2 06/10/23, 15:27
-
Stefan Bürk updated the commit message in patch set 3 06/10/23, 15:35
-
core-ci voted on patch set 1 V -1 06/10/23, 15:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42346
-
core-ci voted on patch set 2 V -1 06/10/23, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42347
-
core-ci voted on patch set 3 V -1 06/10/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42348
-
Stefan Bürk uploaded patch set 4
V -106/10/23, 15:55 -
core-ci voted on patch set 4 V +1 06/10/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42350
-
Stefan Bürk rebased onto patch set 5
V +106/14/23, 23:50 -
core-ci voted on patch set 5 V +1 06/14/23, 23:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42622
-
Oliver Klee voted on patch set 5 V +1 06/15/23, 07:10
-
Benni Mack commented on patch set 5 06/16/23, 22:38
-
Stefan Bürk commented on patch set 5 CR -1 06/18/23, 17:01
Putting this on the table for the next days to recheck, thus -1 for now.PageRouter.php:203ReplyCorrect. Basically this is the fact already if the record slug does not contain the trailing slash. But wait ... there is a redirect then ... will recheck this. Duplicate content is not nice. Will check if in that case the other redirect may be reasonable. -
Stefan Bürk uploaded patch set 6
CR -1V +107/03/23, 11:50 -
Stefan Bürk commented on patch set 6 07/03/23, 11:57
Reply
DonePageRouter.php:203ReplyOkay, the redirect was because of auto-redirect creation. Basically there is no redirect - for the current working solution and the fixed variant with this patch. That means, that there are potential duplicate content scenarious in both cases. However, I would say let us fix this not-resolved variant and target the duplicate content issue in a dedicated change afterwards (TBH have not a solution right now for non of the two cases). -
core-ci voted on patch set 6 V +1 07/03/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43222
-
Benni Mack commented on patch set 6 V +1 CR +1 07/03/23, 12:41
PageRouter.php:203ReplyDone -
Nikita Hovratov voted on patch set 6 V +1 CR +1 07/04/23, 13:28
-
Oliver Klee voted on patch set 6 V +1 07/04/23, 13:51
-
Stefan Bürk voted on patch set 6 V +2 CR +2 07/04/23, 13:56
-
Stefan Bürk merged patch set 7 07/04/23, 13:56
PageRouter.php:203