Review main Merged Breaking

79256[!!!][TASK] Remove deprecated TSFE properties and methods

Benni Mack CR +2 V +2 Hard +33 −247 updated 06/12/23, 09:59

Commit message

Removed public properties:
* TypoScriptFrontendController->intTarget
* TypoScriptFrontendController->extTarget
* TypoScriptFrontendController->fileTarget
* TypoScriptFrontendController->spamProtectEmailAddresses
* TypoScriptFrontendController->baseUrl
* TypoScriptFrontendController->xhtmlDoctype
* TypoScriptFrontendController->xhtmlVersion

Changed visibility from public to protected:
* TypoScriptFrontendController->type

Removed public methods:
* TypoScriptFrontendController->initUserGroups()
* TypoScriptFrontendController->isUserOrGroupSet()
* TypoScriptFrontendController->isBackendUserLoggedIn()
* TypoScriptFrontendController->checkEnableFields()
* TypoScriptFrontendController->baseUrlWrap()
* TypoScriptFrontendController->doWorkspacePreview()
* TypoScriptFrontendController->whichWorkspace()

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 8

Files 8

Review log 1113

  1. Benni Mack uploaded patch set 1 06/12/23, 08:00

  2. core-ci voted on patch set 1 V +1 06/12/23, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42374

  3. Stefan Bürk voted on patch set 1 CR +1 06/12/23, 09:03

  4. Stefan Bürk voted on patch set 1 V +1 06/12/23, 09:13

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 06/12/23, 09:27

  6. Christian Kuhn uploaded patch set 2 CR +1 V +1 06/12/23, 09:44

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 06/12/23, 09:46

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/12/23, 09:46

  9. core-ci voted on patch set 2 V +1 06/12/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42379

  10. Thomas Hohn voted on patch set 2 CR +1 06/12/23, 09:52

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 06/12/23, 09:54

  12. Christian Kuhn voted on patch set 2 V +2 CR +2 06/12/23, 09:59

  13. Christian Kuhn merged patch set 3 06/12/23, 09:59