Review main Merged Breaking

79267[!!!][TASK] Remove legacy TreeView functionality

Benni Mack CR +2 V +2 Hard +41 −452 updated 06/14/23, 22:23

Commit message

Removed classes:
* TYPO3\CMS\Backend\Tree\View\BrowseTreeView
* TYPO3\CMS\Backend\Tree\View\ElementBrowserPageTreeView

Removed methods:
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->determineScriptUrl
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->getThisScript
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->addTagAttributes
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->getRootIcon
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->getRootRecord

Removed properties:
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->thisScript
* TYPO3\CMS\Backend\Tree\View\AbstractTreeView->BE_USER

Various other properties / methods which have been marked as
internal are now properly set as protected.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 3

Files 10

Review log 811

  1. Benni Mack uploaded patch set 1 06/12/23, 20:19

  2. core-ci voted on patch set 1 V +1 06/12/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42403

  3. Christian Kuhn updated the commit message in patch set 2 V +1 06/14/23, 21:50

  4. core-ci voted on patch set 2 V +1 06/14/23, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42614

  5. Christian Kuhn uploaded patch set 3 V +1 06/14/23, 21:59

  6. core-ci voted on patch set 3 V +1 06/14/23, 22:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42615

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 06/14/23, 22:07

  8. Benni Mack commented on patch set 3 06/14/23, 22:11

    thanks for picking it up
  9. Stefan Bürk voted on patch set 3 V +1 CR +1 06/14/23, 22:16

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 06/14/23, 22:23

  11. Christian Kuhn merged patch set 4 06/14/23, 22:23