Review main Merged Breaking

79269[!!!][TASK] Remove deprecated code for cObject and Link Generation

Benni Mack CR +2 V +2 Hard +32 −378 updated 06/13/23, 09:44

Commit message

Removed interfaces:
* TYPO3\CMS\Frontend\ContentObject\Menu\AbstractMenuFilterPagesHookInterface
* TYPO3\CMS\Frontend\ContentObject\TypolinkModifyLinkConfigForPageLinksHookInterface
* TYPO3\CMS\Frontend\Http\UrlProcessorInterface

Removed class alias:
* TYPO3\CMS\Frontend\Typolink\LinkResultFactory

Removed public properties:
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkUrl
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkTarget
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->lastTypoLinkLD

Removed public methods:
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getMailTo
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTreeList
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getATagParams
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTypoLink
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getTypoLink_URL
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getUrlToCurrentLocation
* TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->getQueryArguments
* TYPO3\CMS\Frontend\Typolink\LinkResultFactory->createFromUriString

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 10

Files 13

Review log 710

  1. Benni Mack uploaded patch set 1 06/12/23, 20:40

  2. core-ci voted on patch set 1 V -1 06/12/23, 20:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42405

  3. Benni Mack uploaded patch set 2 V -1 06/12/23, 21:32

  4. core-ci voted on patch set 2 V -1 06/12/23, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42411

  5. Benni Mack uploaded patch set 3 V -1 06/12/23, 21:49

  6. core-ci voted on patch set 3 V +1 06/12/23, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42416

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 06/13/23, 04:35

  8. Thomas Hohn voted on patch set 3 CR +1 06/13/23, 06:08

  9. Christian Kuhn voted on patch set 3 V +2 CR +2 06/13/23, 09:43

  10. Christian Kuhn merged patch set 4 06/13/23, 09:44