Review main Merged Breaking

79272[!!!][TASK] Remove various helper methods related to URL generation

Benni Mack CR +2 V +2 Hard +12 −419 updated 06/13/23, 09:58

Commit message

Removed methods:
* \TYPO3\CMS\Backend\Utility\BackendUtility::getThumbnailUrl
* \TYPO3\CMS\Backend\Utility\BackendUtility::ADMCMD_previewCmds
* \TYPO3\CMS\Backend\Utility\BackendUtility::getPreviewUrl
* \TYPO3\CMS\Backend\Utility\BackendUtility::getLinkToDataHandlerAction
* \TYPO3\CMS\Core\Domain\Repository\PageRepository->getExtURL

Hooks:
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_befunc.php']['viewOnClickClass']

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Thomas Hohn +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 5

Files 8

Review log 68

  1. Benni Mack uploaded patch set 1 06/12/23, 21:47

  2. core-ci voted on patch set 1 V +1 06/12/23, 21:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42414

  3. Benni Mack uploaded patch set 2 V +1 06/13/23, 07:36

  4. Thomas Hohn voted on patch set 2 CR +1 06/13/23, 07:40

  5. core-ci voted on patch set 2 V +1 06/13/23, 07:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42435

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 06/13/23, 09:53

  7. Anja Leichsenring voted on patch set 2 V +2 CR +2 06/13/23, 09:58

  8. Anja Leichsenring merged patch set 3 06/13/23, 09:58