Review main Merged Breaking

79273[!!!][TASK] Remove GU GET/POST related methods

Christian Kuhn CR +2 V +2 Normal +8 −232 updated 06/13/23, 11:56

Commit message

\TYPO3\CMS\Core\Utility\GeneralUtility->_GET
\TYPO3\CMS\Core\Utility\GeneralUtility->_GP
\TYPO3\CMS\Core\Utility\GeneralUtility->_GPmerged
\TYPO3\CMS\Core\Utility\GeneralUtility->_POST

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 6

Files 4

Review log 1217

  1. Christian Kuhn uploaded patch set 1 06/12/23, 21:59

  2. Christian Kuhn uploaded patch set 2 06/12/23, 22:03

  3. Christian Kuhn commented on patch set 2 CR -1 06/12/23, 22:07

    linkThisScript() needs to fall first.
  4. core-ci voted on patch set 1 V -1 06/12/23, 22:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42417

  5. core-ci voted on patch set 2 V -1 06/12/23, 22:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42418

  6. Nikita Hovratov uploaded patch set 3 CR -1 V -1 06/13/23, 10:52

  7. Nikita Hovratov rebased onto patch set 4 06/13/23, 10:54

  8. Christian Kuhn commented on patch set 4 CR -1 06/13/23, 11:02

    needs removal of condition matcher magic first, working on that currently.
  9. core-ci voted on patch set 3 V -1 06/13/23, 11:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42450

  10. core-ci voted on patch set 4 V -1 06/13/23, 11:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42451

  11. Christian Kuhn rebased onto patch set 5 CR -1 V -1 06/13/23, 11:36

  12. core-ci voted on patch set 5 V +1 06/13/23, 11:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42456

  13. Oliver Klee voted on patch set 5 V +1 06/13/23, 11:52

  14. Nikita Hovratov voted on patch set 5 V +1 CR +1 06/13/23, 11:55

  15. Benni Mack voted on patch set 5 V +1 CR +1 06/13/23, 11:55

  16. Christian Kuhn voted on patch set 5 V +2 CR +2 06/13/23, 11:56

  17. Christian Kuhn merged patch set 6 06/13/23, 11:56