Review main Merged Breaking

79320[!!!][TASK] Remove deprecated hooks in UserAuthentication classes

Benni Mack CR +2 V +2 Normal +10 −70 updated 06/13/23, 21:00

Commit message

Hooks removed:
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['postLoginFailureProcessing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['logoff_pre_processing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['logoff_post_processing']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauthgroup.php']['getDefaultUploadFolder']
* $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauthgroup.php']['backendUserLogin']

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Thomas Hohn +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 4

Files 4

Review log 78

  1. Benni Mack uploaded patch set 1 06/13/23, 19:45

  2. core-ci voted on patch set 1 V +1 06/13/23, 19:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42487

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 06/13/23, 20:05

  4. Thomas Hohn voted on patch set 1 CR +1 06/13/23, 20:23

  5. Stefan Bürk voted on patch set 1 V +1 CR +1 06/13/23, 20:27

  6. Oliver Klee voted on patch set 1 V +1 06/13/23, 20:40

  7. Benni Mack voted on patch set 1 V +2 CR +2 06/13/23, 21:00

  8. Benni Mack merged patch set 2 06/13/23, 21:00